Raise ValueError when attempting to set the _CHUNK_SIZE attribute of a TextIOWrapper to a huge value, not TypeError.

pitrou · pitrou · commit 90ce72dd0684 · 2011-07-13T21:08:56.000+02:00
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -225,6 +225,9 @@ Core and Builtins
 Library
 -------
 
+- Raise ValueError when attempting to set the _CHUNK_SIZE attribute of a
+  TextIOWrapper to a huge value, not TypeError.
+
 - Issue #12504: Close file handles in a timely manner in packaging.database.
   This fixes a bug with the remove (uninstall) feature on Windows.
 
diff --git a/Modules/_io/textio.c b/Modules/_io/textio.c
@@ -2618,7 +2618,7 @@ textiowrapper_chunk_size_set(textio *self, PyObject *arg, void *context)
 {
     Py_ssize_t n;
     CHECK_INITIALIZED_INT(self);
-    n = PyNumber_AsSsize_t(arg, PyExc_TypeError);
+    n = PyNumber_AsSsize_t(arg, PyExc_ValueError);
     if (n == -1 && PyErr_Occurred())
         return -1;
     if (n <= 0) {

Original file line number	Diff line number	Diff line change
`@@ -2618,7 +2618,7 @@ textiowrapper_chunk_size_set(textio self, PyObject arg, void *context)`
`2618`	`2618`	`{`
`2619`	`2619`	`Py_ssize_t n;`
`2620`	`2620`	`CHECK_INITIALIZED_INT(self);`
`2621`		`- n = PyNumber_AsSsize_t(arg, PyExc_TypeError);`
	`2621`	`+ n = PyNumber_AsSsize_t(arg, PyExc_ValueError);`
`2622`	`2622`	`if (n == -1 && PyErr_Occurred())`
`2623`	`2623`	`return -1;`
`2624`	`2624`	`if (n <= 0) {`