bpo-34735: Fix a memory leak in Modules/timemodule.c (GH-9418)

ZackerySpytz · serhiy-storchaka · commit 91e6c8717b7d · 2018-09-21T09:09:48.000+03:00
There was a missing PyMem_Free(format) in time_strftime().
diff --git a/Misc/NEWS.d/next/Core and Builtins/2018-09-19-06-57-34.bpo-34735.-3mrSJ.rst b/Misc/NEWS.d/next/Core and Builtins/2018-09-19-06-57-34.bpo-34735.-3mrSJ.rst
@@ -0,0 +1 @@
+Fix a memory leak in Modules/timemodule.c.  Patch by Zackery Spytz.
diff --git a/Modules/timemodule.c b/Modules/timemodule.c
@@ -801,6 +801,7 @@ time_strftime(PyObject *self, PyObject *args)
         if (outbuf[1] == L'y' && buf.tm_year < 0) {
             PyErr_SetString(PyExc_ValueError,
                             "format %y requires year >= 1900 on AIX");
+            PyMem_Free(format);
             return NULL;
         }
     }

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Fix a memory leak in Modules/timemodule.c. Patch by Zackery Spytz.`
Original file line number	Diff line number	Diff line change
`@@ -801,6 +801,7 @@ time_strftime(PyObject self, PyObject args)`
`801`	`801`	`if (outbuf[1] == L'y' && buf.tm_year < 0) {`
`802`	`802`	`PyErr_SetString(PyExc_ValueError,`
`803`	`803`	`"format %y requires year >= 1900 on AIX");`
	`804`	`+ PyMem_Free(format);`
`804`	`805`	`return NULL;`
`805`	`806`	`}`
`806`	`807`	`}`