Issue 3068: Move idlelib.configDialog action button creation into a separate

terryjreedy · terryjreedy · commit 92cb0a361f7b · 2014-10-08T20:29:13.000-04:00
method so it can be reused by the new extension dialog.
diff --git a/Lib/idlelib/configDialog.py b/Lib/idlelib/configDialog.py
@@ -79,39 +79,41 @@ def __init__(self, parent, title, _htest=False, _utest=False):
     def CreateWidgets(self):
         self.tabPages = TabbedPageSet(self,
                 page_names=['Fonts/Tabs', 'Highlighting', 'Keys', 'General'])
-        frameActionButtons = Frame(self, pady=2)
-        #action buttons
+        self.tabPages.pack(side=TOP, expand=TRUE, fill=BOTH)
+        self.CreatePageFontTab()
+        self.CreatePageHighlight()
+        self.CreatePageKeys()
+        self.CreatePageGeneral()
+        self.create_action_buttons().pack(side=BOTTOM)
+        Frame(self, height=2, borderwidth=0).pack(side=BOTTOM)
+
+    def create_action_buttons(self):
         if macosxSupport.isAquaTk():
             # Changing the default padding on OSX results in unreadable
             # text in the buttons
             paddingArgs = {}
         else:
             paddingArgs = {'padx':6, 'pady':3}
 
-# Comment out button creation and packing until implement self.Help
-##        self.buttonHelp = Button(frameActionButtons, text='Help',
-##                command=self.Help, takefocus=FALSE,
-##                **paddingArgs)
+        frame = Frame(self, pady=2)
         self.buttonOk = Button(
-                frameActionButtons, text='Ok',
-                command=self.Ok, takefocus=FALSE, **paddingArgs)
+                frame, text='Ok', command=self.Ok,
+                takefocus=FALSE, **paddingArgs)
         self.buttonApply = Button(
-                frameActionButtons, text='Apply',
-                command=self.Apply, takefocus=FALSE, **paddingArgs)
+                frame, text='Apply', command=self.Apply,
+                takefocus=FALSE, **paddingArgs)
         self.buttonCancel = Button(
-                frameActionButtons, text='Cancel',
-                command=self.Cancel, takefocus=FALSE, **paddingArgs)
-        self.CreatePageFontTab()
-        self.CreatePageHighlight()
-        self.CreatePageKeys()
-        self.CreatePageGeneral()
+                frame, text='Cancel', command=self.Cancel,
+                takefocus=FALSE, **paddingArgs)
+# Comment out Help button creation and packing until implement self.Help
+##        self.buttonHelp = Button(
+##                frame, text='Help', command=self.Help,
+##                takefocus=FALSE, **paddingArgs)
 ##        self.buttonHelp.pack(side=RIGHT, padx=5)
         self.buttonOk.pack(side=LEFT, padx=5)
         self.buttonApply.pack(side=LEFT, padx=5)
         self.buttonCancel.pack(side=LEFT, padx=5)
-        frameActionButtons.pack(side=BOTTOM)
-        Frame(self, height=2, borderwidth=0).pack(side=BOTTOM)
-        self.tabPages.pack(side=TOP, expand=TRUE, fill=BOTH)
+        return frame
 
     def CreatePageFontTab(self):
         parent = self.parent
