Issue #20947: Fixed a gcc warning with -Wstrict-overflow.

serhiy-storchaka · serhiy-storchaka · commit 9574e0adf287 · 2016-09-27T22:04:45.000+03:00
diff --git a/Modules/_posixsubprocess.c b/Modules/_posixsubprocess.c
@@ -521,7 +521,7 @@ child_exec(char *const exec_array[],
         char *cur;
         _Py_write_noraise(errpipe_write, "OSError:", 8);
         cur = hex_errno + sizeof(hex_errno);
-        while (saved_errno != 0 && cur > hex_errno) {
+        while (saved_errno != 0 && cur != hex_errno) {
             *--cur = Py_hexdigits[saved_errno % 16];
             saved_errno /= 16;
         }

Original file line number	Diff line number	Diff line change
`@@ -521,7 +521,7 @@ child_exec(char *const exec_array[],`
`521`	`521`	`char *cur;`
`522`	`522`	`_Py_write_noraise(errpipe_write, "OSError:", 8);`
`523`	`523`	`cur = hex_errno + sizeof(hex_errno);`
`524`		`- while (saved_errno != 0 && cur > hex_errno) {`
	`524`	`+ while (saved_errno != 0 && cur != hex_errno) {`
`525`	`525`	`*--cur = Py_hexdigits[saved_errno % 16];`
`526`	`526`	`saved_errno /= 16;`
`527`	`527`	`}`