Use ValueError, not RuntimeError for a utime flag combination illegal on some systems.

birkenfeld · birkenfeld · commit 969288e488f6 · 2012-06-26T09:25:44.000+02:00
diff --git a/Lib/test/test_posix.py b/Lib/test/test_posix.py
@@ -730,7 +730,7 @@ def test_utime_dir_fd(self):
             if os.utime in os.supports_follow_symlinks:
                 try:
                     posix.utime(support.TESTFN, follow_symlinks=False, dir_fd=f)
-                except RuntimeError:
+                except ValueError:
                     # whoops!  using both together not supported on this platform.
                     pass
 
diff --git a/Modules/posixmodule.c b/Modules/posixmodule.c
@@ -4667,7 +4667,7 @@ posix_utime(PyObject *self, PyObject *args, PyObject *kwargs)
 
 #if !defined(HAVE_UTIMENSAT)
     if ((dir_fd != DEFAULT_DIR_FD) && (!follow_symlinks)) {
-        PyErr_SetString(PyExc_RuntimeError,
+        PyErr_SetString(PyExc_ValueError,
                      "utime: cannot use dir_fd and follow_symlinks "
                      "together on this platform");
         goto exit;
