Avoid useless "++" at the end of functions

Victor Stinner · Victor Stinner · commit 97e561ef24b6 · 2011-05-26T13:53:47.000+02:00
Warnings found by the Clang Static Analyzer.
diff --git a/Objects/setobject.c b/Objects/setobject.c
@@ -612,9 +612,9 @@ set_repr(PySetObject *so)
         *u++ = '{';
         /* Omit the brackets from the listrepr */
         Py_UNICODE_COPY(u, PyUnicode_AS_UNICODE(listrepr)+1,
-                           PyUnicode_GET_SIZE(listrepr)-2);
+                           newsize-2);
         u += newsize-2;
-        *u++ = '}';
+        *u = '}';
     }
     Py_DECREF(listrepr);
     if (Py_TYPE(so) != &PySet_Type) {
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -6474,7 +6474,7 @@ PyUnicode_EncodeDecimal(Py_UNICODE *s,
         }
     }
     /* 0-terminate the output string */
-    *output++ = '\0';
+    *output = '\0';
     Py_XDECREF(exc);
     Py_XDECREF(errorHandler);
     return 0;
diff --git a/Python/compile.c b/Python/compile.c
@@ -3747,11 +3747,11 @@ assemble_lnotab(struct assembler *a, struct instr *i)
     a->a_lnotab_off += 2;
     if (d_bytecode) {
         *lnotab++ = d_bytecode;
-        *lnotab++ = d_lineno;
+        *lnotab = d_lineno;
     }
     else {      /* First line of a block; def stmt, etc. */
         *lnotab++ = 0;
-        *lnotab++ = d_lineno;
+        *lnotab = d_lineno;
     }
     a->a_lineno = i->i_lineno;
     a->a_lineno_off = a->a_offset;
@@ -3796,7 +3796,7 @@ assemble_emit(struct assembler *a, struct instr *i)
     if (i->i_hasarg) {
         assert(size == 3 || size == 6);
         *code++ = arg & 0xff;
-        *code++ = arg >> 8;
+        *code = arg >> 8;
     }
     return 1;
 }

Original file line number	Diff line number	Diff line change
`@@ -6474,7 +6474,7 @@ PyUnicode_EncodeDecimal(Py_UNICODE *s,`
`6474`	`6474`	`}`
`6475`	`6475`	`}`
`6476`	`6476`	`/* 0-terminate the output string */`
`6477`		`- *output++ = '\0';`
	`6477`	`+ *output = '\0';`
`6478`	`6478`	`Py_XDECREF(exc);`
`6479`	`6479`	`Py_XDECREF(errorHandler);`
`6480`	`6480`	`return 0;`
Original file line number	Diff line number	Diff line change
`@@ -3747,11 +3747,11 @@ assemble_lnotab(struct assembler a, struct instr i)`
`3747`	`3747`	`a->a_lnotab_off += 2;`
`3748`	`3748`	`if (d_bytecode) {`
`3749`	`3749`	`*lnotab++ = d_bytecode;`
`3750`		`- *lnotab++ = d_lineno;`
	`3750`	`+ *lnotab = d_lineno;`
`3751`	`3751`	`}`
`3752`	`3752`	`else { /* First line of a block; def stmt, etc. */`
`3753`	`3753`	`*lnotab++ = 0;`
`3754`		`- *lnotab++ = d_lineno;`
	`3754`	`+ *lnotab = d_lineno;`
`3755`	`3755`	`}`
`3756`	`3756`	`a->a_lineno = i->i_lineno;`
`3757`	`3757`	`a->a_lineno_off = a->a_offset;`
`@@ -3796,7 +3796,7 @@ assemble_emit(struct assembler a, struct instr i)`
`3796`	`3796`	`if (i->i_hasarg) {`
`3797`	`3797`	`assert(size == 3 \|\| size == 6);`
`3798`	`3798`	`*code++ = arg & 0xff;`
`3799`		`- *code++ = arg >> 8;`
	`3799`	`+ *code = arg >> 8;`
`3800`	`3800`	`}`
`3801`	`3801`	`return 1;`
`3802`	`3802`	`}`