Remove an obsolete comment and a "return" before fallig off the end of a

freddrake · freddrake · commit 9b03e59deb49 · 2001-05-03T16:05:46.000Z
void function.
diff --git a/Modules/_weakref.c b/Modules/_weakref.c
@@ -736,7 +736,6 @@ cleanup_helper(PyObject *object)
         || !PyType_SUPPORTS_WEAKREFS(object->ob_type)
         || object->ob_refcnt != 0) {
         PyErr_BadInternalCall();
-        /* not sure what we should return here */
         return;
     }
     list = GET_WEAKREFS_LISTPTR(object);
@@ -792,7 +791,6 @@ cleanup_helper(PyObject *object)
             Py_DECREF(tuple);
         }
     }
-    return;
 }
 
 

Original file line number	Diff line number	Diff line change
`@@ -736,7 +736,6 @@ cleanup_helper(PyObject *object)`
`736`	`736`	`\|\| !PyType_SUPPORTS_WEAKREFS(object->ob_type)`
`737`	`737`	`\|\| object->ob_refcnt != 0) {`
`738`	`738`	`PyErr_BadInternalCall();`
`739`		`- /* not sure what we should return here */`
`740`	`739`	`return;`
`741`	`740`	`}`
`742`	`741`	`list = GET_WEAKREFS_LISTPTR(object);`
`@@ -792,7 +791,6 @@ cleanup_helper(PyObject *object)`
`792`	`791`	`Py_DECREF(tuple);`
`793`	`792`	`}`
`794`	`793`	`}`
`795`		`- return;`
`796`	`794`	`}`
`797`	`795`
`798`	`796`