Fix refcnt for temp variables

XuehaiPan · XuehaiPan · commit 9e6cd98d4289 · 2023-10-03T00:54:30.000+08:00
diff --git a/Objects/structseq.c b/Objects/structseq.c
@@ -419,9 +419,11 @@ structseq_replace(PyStructSequence *self, PyObject *args, PyObject *kwargs)
                 goto error;
             }
             PyObject *ob = _PyDict_Pop(kwargs, key, self->ob_item[i]);
-            if (PyDict_SetItem(dict, key, ob) < 0) {
+            if (!ob || PyDict_SetItem(dict, key, ob) < 0) {
+                Py_DECREF(key);
                 goto error;
             }
+            Py_DECREF(key);
         }
         if (PyDict_Size(kwargs) > 0) {
             PyObject *names = PyDict_Keys(kwargs);

Original file line number	Diff line number	Diff line change
`@@ -419,9 +419,11 @@ structseq_replace(PyStructSequence self, PyObject args, PyObject *kwargs)`
`419`	`419`	`goto error;`
`420`	`420`	`}`
`421`	`421`	`PyObject *ob = _PyDict_Pop(kwargs, key, self->ob_item[i]);`
`422`		`- if (PyDict_SetItem(dict, key, ob) < 0) {`
	`422`	`+ if (!ob \|\| PyDict_SetItem(dict, key, ob) < 0) {`
	`423`	`+ Py_DECREF(key);`
`423`	`424`	`goto error;`
`424`	`425`	`}`
	`426`	`+ Py_DECREF(key);`
`425`	`427`	`}`
`426`	`428`	`if (PyDict_Size(kwargs) > 0) {`
`427`	`429`	`PyObject *names = PyDict_Keys(kwargs);`