bpo-35356: Fix a possible reference leak in nis.maps(). (GH-10808)

ZackerySpytz · serhiy-storchaka · commit a2e3585e79c9 · 2018-11-30T09:40:16.000+02:00
diff --git a/Modules/nismodule.c b/Modules/nismodule.c
@@ -412,6 +412,7 @@ nis_maps (PyObject *self, PyObject *args, PyObject *kwdict)
         PyObject *str = PyUnicode_FromString(maps->map);
         if (!str || PyList_Append(list, str) < 0)
         {
+            Py_XDECREF(str);
             Py_DECREF(list);
             list = NULL;
             break;

Original file line number	Diff line number	Diff line change
`@@ -412,6 +412,7 @@ nis_maps (PyObject self, PyObject args, PyObject *kwdict)`
`412`	`412`	`PyObject *str = PyUnicode_FromString(maps->map);`
`413`	`413`	`if (!str \|\| PyList_Append(list, str) < 0)`
`414`	`414`	`{`
	`415`	`+ Py_XDECREF(str);`
`415`	`416`	`Py_DECREF(list);`
`416`	`417`	`list = NULL;`
`417`	`418`	`break;`