Fix potential NULL pointer dereference in _imp_create_builtin

tiran · tiran · commit a78b627e2b8e · 2016-09-09T00:25:03.000+02:00
PyModule_GetDef() can return NULL. Let's check the return value properly
like in the other five cases.

CID 1299590
diff --git a/Python/import.c b/Python/import.c
@@ -1077,6 +1077,10 @@ _imp_create_builtin(PyObject *module, PyObject *spec)
             } else {
                 /* Remember pointer to module init function. */
                 def = PyModule_GetDef(mod);
+                if (def == NULL) {
+                    Py_DECREF(name);
+                    return NULL;
+                }
                 def->m_base.m_init = p->initfunc;
                 if (_PyImport_FixupExtensionObject(mod, name, name) < 0) {
                     Py_DECREF(name);
