Issue #18342: Use the repr of a module name for ``from ... import

brettcannon · brettcannon · commit a79e4fb38d6e · 2013-07-12T11:22:26.000-04:00
...`` when an ImportError occurs.

Other cases had already been switched over to using the repr.

Thanks to Tomasz Maćkowiak for the patch.
diff --git a/Lib/test/test_import.py b/Lib/test/test_import.py
@@ -321,6 +321,14 @@ def test_delete_builtins_import(self):
         stdout, stderr = popen.communicate()
         self.assertIn(b"ImportError", stdout)
 
+    def test_from_import_message_for_nonexistent_module(self):
+        with self.assertRaisesRegexp(ImportError, "^No module named 'bogus'"):
+            from bogus import foo
+
+    def test_from_import_message_for_existing_module(self):
+        with self.assertRaisesRegexp(ImportError, "^cannot import name 'bogus'"):
+            from re import bogus
+
 
 @skip_if_dont_write_bytecode
 class FilePermissionTests(unittest.TestCase):
diff --git a/Misc/ACKS b/Misc/ACKS
@@ -786,6 +786,7 @@ Andrew I MacIntyre
 Tim MacKenzie
 Nick Maclaren
 Don MacMillen
+Tomasz Maćkowiak
 Steve Majewski
 Grzegorz Makarewicz
 David Malcolm
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -10,6 +10,9 @@ What's New in Python 3.4.0 Alpha 1?
 Core and Builtins
 -----------------
 
+- Issue #18342: Use the repr of a module name when an import fails when using
+  ``from ... import ...``.
+
 - Issue #17872: Fix a segfault in marshal.load() when input stream returns
   more bytes than requested.
 
diff --git a/Python/ceval.c b/Python/ceval.c
@@ -4602,7 +4602,7 @@ import_from(PyObject *v, PyObject *name)
 
     x = PyObject_GetAttr(v, name);
     if (x == NULL && PyErr_ExceptionMatches(PyExc_AttributeError)) {
-        PyErr_Format(PyExc_ImportError, "cannot import name %S", name);
+        PyErr_Format(PyExc_ImportError, "cannot import name %R", name);
     }
     return x;
 }

Original file line number	Diff line number	Diff line change
`@@ -4602,7 +4602,7 @@ import_from(PyObject v, PyObject name)`
`4602`	`4602`
`4603`	`4603`	`x = PyObject_GetAttr(v, name);`
`4604`	`4604`	`if (x == NULL && PyErr_ExceptionMatches(PyExc_AttributeError)) {`
`4605`		`- PyErr_Format(PyExc_ImportError, "cannot import name %S", name);`
	`4605`	`+ PyErr_Format(PyExc_ImportError, "cannot import name %R", name);`
`4606`	`4606`	`}`
`4607`	`4607`	`return x;`
`4608`	`4608`	`}`