Fred's right -- we need PyList_SET_ITEM().

gvanrossum · gvanrossum · commit a937d14898e8 · 1998-04-24T18:22:02.000Z
diff --git a/Doc/api.tex b/Doc/api.tex
@@ -1953,6 +1953,11 @@ \subsection{List Objects}
 Macro form of \cfunction{PyList_GetItem()} without error checking.
 \end{cfuncdesc}
 
+\begin{cfuncdesc}{PyObject*}{PyList_SET_ITEM}{PyObject *list, int i,
+                                              PyObject *o}
+Macro form of \cfunction{PyList_SetItem()} without error checking.
+\end{cfuncdesc}
+
 \begin{cfuncdesc}{int}{PyList_GET_SIZE}{PyObject *list}
 Macro form of \cfunction{PyList_GetSize()} without error checking.
 \end{cfuncdesc}
diff --git a/Doc/api/api.tex b/Doc/api/api.tex
@@ -1953,6 +1953,11 @@ \subsection{List Objects}
 Macro form of \cfunction{PyList_GetItem()} without error checking.
 \end{cfuncdesc}
 
+\begin{cfuncdesc}{PyObject*}{PyList_SET_ITEM}{PyObject *list, int i,
+                                              PyObject *o}
+Macro form of \cfunction{PyList_SetItem()} without error checking.
+\end{cfuncdesc}
+
 \begin{cfuncdesc}{int}{PyList_GET_SIZE}{PyObject *list}
 Macro form of \cfunction{PyList_GetSize()} without error checking.
 \end{cfuncdesc}
diff --git a/Include/listobject.h b/Include/listobject.h
@@ -74,6 +74,7 @@ extern PyObject *PyList_AsTuple Py_PROTO((PyObject *));
 
 /* Macro, trading safety for speed */
 #define PyList_GET_ITEM(op, i) (((PyListObject *)(op))->ob_item[i])
+#define PyList_SET_ITEM(op, i, v) (((PyListObject *)(op))->ob_item[i] = (v))
 #define PyList_GET_SIZE(op)    (((PyListObject *)(op))->ob_size)
 
 #ifdef __cplusplus
diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c
@@ -1282,7 +1282,7 @@ builtin_range(self, args)
 			Py_DECREF(v);
 			return NULL;
 		}
-		PyList_GET_ITEM(v, i) = w;
+		PyList_SET_ITEM(v, i, w);
 		ilow += istep;
 	}
 	return v;

Original file line number	Diff line number	Diff line change
`@@ -1282,7 +1282,7 @@ builtin_range(self, args)`
`1282`	`1282`	`Py_DECREF(v);`
`1283`	`1283`	`return NULL;`
`1284`	`1284`	`}`
`1285`		`- PyList_GET_ITEM(v, i) = w;`
	`1285`	`+ PyList_SET_ITEM(v, i, w);`
`1286`	`1286`	`ilow += istep;`
`1287`	`1287`	`}`
`1288`	`1288`	`return v;`