Found another memory leak in longrangeiter. And redo the previous correction

amauryfa · amauryfa · commit b7f17e4bb462 · 2007-11-15T20:52:21.000Z
without calling PyType_Ready().

Question 1: Should the interpreter register all types with PyType_Ready()?
Many types seem to avoid it.

Question 2: To reproduce the problem, run the following code:
    def f():
        while True:
           for a in iter(range(0,1,10**20)):
              pass
    f()
And watch the memory used by the process.
How do we test this in a unittest?
diff --git a/Objects/object.c b/Objects/object.c
@@ -1509,9 +1509,6 @@ _Py_ReadyTypes(void)
 
 	if (PyType_Ready(&PyStdPrinter_Type) < 0)
 		Py_FatalError("Can't initialize StdPrinter");
-
-	if (PyType_Ready(&PyRange_Type) < 0)
-		Py_FatalError("Can't initialize 'range'");
 }
 
 
diff --git a/Objects/rangeobject.c b/Objects/rangeobject.c
@@ -107,7 +107,7 @@ range_dealloc(rangeobject *r)
     Py_DECREF(r->start);
     Py_DECREF(r->stop);
     Py_DECREF(r->step);
-    Py_Type(r)->tp_free(r);
+    PyObject_Del(r);
 }
 
 /* Return number of items in range (lo, hi, step), when arguments are
@@ -482,6 +482,7 @@ longrangeiter_dealloc(longrangeiterobject *r)
     Py_XDECREF(r->start);
     Py_XDECREF(r->step);
     Py_XDECREF(r->len);
+    PyObject_Del(r);
 }
 
 static PyObject *

Original file line number	Diff line number	Diff line change
`@@ -1509,9 +1509,6 @@ _Py_ReadyTypes(void)`
`1509`	`1509`
`1510`	`1510`	`if (PyType_Ready(&PyStdPrinter_Type) < 0)`
`1511`	`1511`	`Py_FatalError("Can't initialize StdPrinter");`
`1512`		`-`
`1513`		`- if (PyType_Ready(&PyRange_Type) < 0)`
`1514`		`- Py_FatalError("Can't initialize 'range'");`
`1515`	`1512`	`}`
`1516`	`1513`
`1517`	`1514`
Original file line number	Diff line number	Diff line change
`@@ -107,7 +107,7 @@ range_dealloc(rangeobject *r)`
`107`	`107`	`Py_DECREF(r->start);`
`108`	`108`	`Py_DECREF(r->stop);`
`109`	`109`	`Py_DECREF(r->step);`
`110`		`- Py_Type(r)->tp_free(r);`
	`110`	`+ PyObject_Del(r);`
`111`	`111`	`}`
`112`	`112`
`113`	`113`	`/* Return number of items in range (lo, hi, step), when arguments are`
`@@ -482,6 +482,7 @@ longrangeiter_dealloc(longrangeiterobject *r)`
`482`	`482`	`Py_XDECREF(r->start);`
`483`	`483`	`Py_XDECREF(r->step);`
`484`	`484`	`Py_XDECREF(r->len);`
	`485`	`+ PyObject_Del(r);`
`485`	`486`	`}`
`486`	`487`
`487`	`488`	`static PyObject *`