Issue #19437: Fix parse_save_field() of the csv module, handle PyList_Append()

vstinner · vstinner · commit b80b37868069 · 2013-11-14T21:29:34.000+01:00
failure
diff --git a/Modules/_csv.c b/Modules/_csv.c
@@ -546,7 +546,10 @@ parse_save_field(ReaderObj *self)
             return -1;
         field = tmp;
     }
-    PyList_Append(self->fields, field);
+    if (PyList_Append(self->fields, field) < 0) {
+        Py_DECREF(field);
+        return -1;
+    }
     Py_DECREF(field);
     return 0;
 }

Original file line number	Diff line number	Diff line change
`@@ -546,7 +546,10 @@ parse_save_field(ReaderObj *self)`
`546`	`546`	`return -1;`
`547`	`547`	`field = tmp;`
`548`	`548`	`}`
`549`		`- PyList_Append(self->fields, field);`
	`549`	`+ if (PyList_Append(self->fields, field) < 0) {`
	`550`	`+ Py_DECREF(field);`
	`551`	`+ return -1;`
	`552`	`+ }`
`550`	`553`	`Py_DECREF(field);`
`551`	`554`	`return 0;`
`552`	`555`	`}`