#12353: argparse now correctly handles null argument values.

bitdancer · bitdancer · commit b94082a71b6b · 2012-07-21T22:20:11.000-04:00
Patch by Torsten Landschoff.
diff --git a/Lib/argparse.py b/Lib/argparse.py
@@ -1976,7 +1976,7 @@ def _read_args_from_files(self, arg_strings):
         for arg_string in arg_strings:
 
             # for regular arguments, just add them back into the list
-            if arg_string[0] not in self.fromfile_prefix_chars:
+            if not arg_string or arg_string[0] not in self.fromfile_prefix_chars:
                 new_arg_strings.append(arg_string)
 
             # replace arguments referencing files with the file content
diff --git a/Lib/test/test_argparse.py b/Lib/test/test_argparse.py
@@ -1371,6 +1371,7 @@ def setUp(self):
         ('X @hello', NS(a=None, x='X', y=['hello world!'])),
         ('-a B @recursive Y Z', NS(a='A', x='hello world!', y=['Y', 'Z'])),
         ('X @recursive Z -a B', NS(a='B', x='X', y=['hello world!', 'Z'])),
+        (["-a", "", "X", "Y"], NS(a='', x='X', y=['Y'])),
     ]
 
 
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -98,6 +98,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #12353: argparse now correctly handles null argument values.
+
 - Issues #10017 and #14998: Fix TypeError using pprint on dictionaries with
   user-defined types as keys or other unorderable keys.
 

Original file line number	Diff line number	Diff line change
`@@ -1371,6 +1371,7 @@ def setUp(self):`
`1371`	`1371`	`('X @hello', NS(a=None, x='X', y=['hello world!'])),`
`1372`	`1372`	`('-a B @recursive Y Z', NS(a='A', x='hello world!', y=['Y', 'Z'])),`
`1373`	`1373`	`('X @recursive Z -a B', NS(a='B', x='X', y=['hello world!', 'Z'])),`
	`1374`	`+ (["-a", "", "X", "Y"], NS(a='', x='X', y=['Y'])),`
`1374`	`1375`	`]`
`1375`	`1376`
`1376`	`1377`