Fix a refleak in _sre

brettcannon · brettcannon · commit baced5668a5d · 2013-10-18T14:03:16.000-04:00
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -54,6 +54,8 @@ Core and Builtins
 Library
 -------
 
+- Fix a reference count leak in _sre.
+
 - Issue #19262: Initial check in of the 'asyncio' package (a.k.a. Tulip,
   a.k.a. PEP 3156).  There are no docs yet, and the PEP is slightly
   out of date with the code.  This module will have *provisional* status
diff --git a/Modules/_sre.c b/Modules/_sre.c
@@ -2427,6 +2427,7 @@ pattern_subx(PatternObject* self, PyObject* ptemplate, PyObject* string,
         else
             item = PyUnicode_Join(joiner, list);
         Py_DECREF(joiner);
+        Py_DECREF(list);
         if (!item)
             return NULL;
     }

Original file line number	Diff line number	Diff line change
`@@ -2427,6 +2427,7 @@ pattern_subx(PatternObject* self, PyObject* ptemplate, PyObject* string,`
`2427`	`2427`	`else`
`2428`	`2428`	`item = PyUnicode_Join(joiner, list);`
`2429`	`2429`	`Py_DECREF(joiner);`
	`2430`	`+ Py_DECREF(list);`
`2430`	`2431`	`if (!item)`
`2431`	`2432`	`return NULL;`
`2432`	`2433`	`}`