Issue #22247: Add NNTPError to nntplib.__all__.

berkerpeksag · berkerpeksag · commit bdfeb0387dce · 2014-09-20T08:54:32.000+03:00
diff --git a/Lib/nntplib.py b/Lib/nntplib.py
@@ -80,8 +80,8 @@
 from socket import _GLOBAL_DEFAULT_TIMEOUT
 
 __all__ = ["NNTP",
-           "NNTPReplyError", "NNTPTemporaryError", "NNTPPermanentError",
-           "NNTPProtocolError", "NNTPDataError",
+           "NNTPError", "NNTPReplyError", "NNTPTemporaryError",
+           "NNTPPermanentError", "NNTPProtocolError", "NNTPDataError",
            "decode_header",
            ]
 
diff --git a/Lib/test/test_nntplib.py b/Lib/test/test_nntplib.py
@@ -1412,11 +1412,18 @@ def gives(y, M, d, date_str, time_str):
     def test_ssl_support(self):
         self.assertTrue(hasattr(nntplib, 'NNTP_SSL'))
 
-def test_main():
-    tests = [MiscTests, NNTPv1Tests, NNTPv2Tests, CapsAfterLoginNNTPv2Tests,
-            SendReaderNNTPv2Tests, NetworkedNNTPTests, NetworkedNNTP_SSLTests]
-    support.run_unittest(*tests)
 
+class PublicAPITests(unittest.TestCase):
+    """Ensures that the correct values are exposed in the public API."""
+
+    def test_module_all_attribute(self):
+        self.assertTrue(hasattr(nntplib, '__all__'))
+        target_api = ['NNTP', 'NNTPError', 'NNTPReplyError',
+                      'NNTPTemporaryError', 'NNTPPermanentError',
+                      'NNTPProtocolError', 'NNTPDataError', 'decode_header']
+        if ssl is not None:
+            target_api.append('NNTP_SSL')
+        self.assertEqual(set(nntplib.__all__), set(target_api))
 
 if __name__ == "__main__":
-    test_main()
+    unittest.main()
diff --git a/Misc/NEWS b/Misc/NEWS
@@ -137,6 +137,8 @@ Core and Builtins
 Library
 -------
 
+- Issue #22247: Add NNTPError to nntplib.__all__.
+
 - Issue #22366: urllib.request.urlopen will accept a context object
   (SSLContext) as an argument which will then used be for HTTPS connection.
   Patch by Alex Gaynor.

Original file line number	Diff line number	Diff line change
`@@ -80,8 +80,8 @@`
`80`	`80`	`from socket import _GLOBAL_DEFAULT_TIMEOUT`
`81`	`81`
`82`	`82`	`__all__ = ["NNTP",`
`83`		`- "NNTPReplyError", "NNTPTemporaryError", "NNTPPermanentError",`
`84`		`- "NNTPProtocolError", "NNTPDataError",`
	`83`	`+ "NNTPError", "NNTPReplyError", "NNTPTemporaryError",`
	`84`	`+ "NNTPPermanentError", "NNTPProtocolError", "NNTPDataError",`
`85`	`85`	`"decode_header",`
`86`	`86`	`]`
`87`	`87`