gh-120041: Refactor check for visible completion menu in completing_reader (#120055)

lysnikolaou · web-flow · commit bf8e5e53d0c3 · 2024-06-04T19:26:44.000+02:00
diff --git a/Lib/_pyrepl/commands.py b/Lib/_pyrepl/commands.py
@@ -365,12 +365,7 @@ def do(self) -> None:
         r = self.reader
         text = self.event * r.get_arg()
         r.insert(text)
-        if (
-            len(text) == 1 and
-            r.pos == len(r.buffer) and
-            not r.cmpltn_menu_visible and  # type: ignore[attr-defined]
-            not r.cmpltn_message_visible  # type: ignore[attr-defined]
-        ):
+        if len(text) == 1 and r.pos == len(r.buffer):
             r.calc_screen = r.append_to_screen
 
 
diff --git a/Lib/_pyrepl/completing_reader.py b/Lib/_pyrepl/completing_reader.py
@@ -210,6 +210,9 @@ def do(self) -> None:
 
         commands.self_insert.do(self)
 
+        if r.cmpltn_menu_visible or r.cmpltn_message_visible:
+            r.calc_screen = r.calc_complete_screen
+
         if r.cmpltn_menu_visible:
             stem = r.get_stem()
             if len(stem) < 1:
