gh-69093: improve sqlite3.Connection.blobopen() error handling (GH-91571)

Erlend Egeberg Aasland · web-flow · commit c06a4ffe818f · 2022-04-15T09:27:39.000-07:00
Unless sqlite3_blob_open() returns SQLITE_MISUSE, the error code and
message are available on the connection object. This means we have to
handle SQLITE_MISUSE error messages explicitly.
diff --git a/Modules/_sqlite/connection.c b/Modules/_sqlite/connection.c
@@ -475,7 +475,11 @@ blobopen_impl(pysqlite_Connection *self, const char *table, const char *col,
     rc = sqlite3_blob_open(self->db, name, table, col, row, !readonly, &blob);
     Py_END_ALLOW_THREADS
 
-    if (rc != SQLITE_OK) {
+    if (rc == SQLITE_MISUSE) {
+        PyErr_Format(self->state->InterfaceError, sqlite3_errstr(rc));
+        return NULL;
+    }
+    else if (rc != SQLITE_OK) {
         _pysqlite_seterror(self->state, self->db);
         return NULL;
     }
