Clarify return value of PyLong_AsLongLong().

jeremyhylton · jeremyhylton · commit c4ad0bcbe589 · 2002-04-23T20:01:20.000Z
The function is documented to return -1 on error.  If res was &lt; 0, it
returned res.  It wasn't clear that the invariant was res &lt; 0 iff res
== -1.
diff --git a/Objects/longobject.c b/Objects/longobject.c
@@ -696,7 +696,7 @@ PyLong_AsLongLong(PyObject *vv)
 
 	/* Plan 9 can't handle LONG_LONG in ? : expressions */
 	if (res < 0)
-		return (LONG_LONG)res;
+		return (LONG_LONG)-1;
 	else
 		return bytes;
 }

Original file line number	Diff line number	Diff line change
`@@ -696,7 +696,7 @@ PyLong_AsLongLong(PyObject *vv)`
`696`	`696`
`697`	`697`	`/* Plan 9 can't handle LONG_LONG in ? : expressions */`
`698`	`698`	`if (res < 0)`
`699`		`- return (LONG_LONG)res;`
	`699`	`+ return (LONG_LONG)-1;`
`700`	`700`	`else`
`701`	`701`	`return bytes;`
`702`	`702`	`}`