Initialize Attr.value with empty string in createAttribute*, as per DOM

loewis · loewis · commit cb67ea1d6e2d · 2001-03-31T16:30:40.000Z
spec. Closes bug #412036.
Also reindent toprettyxml.
diff --git a/Lib/xml/dom/minidom.py b/Lib/xml/dom/minidom.py
@@ -87,11 +87,11 @@ def toxml(self):
         return writer.getvalue()
 
     def toprettyxml(self, indent="\t", newl="\n"):
-      # indent = the indentation string to prepend, per level
-      # newl = the newline string to append
-      writer = _get_StringIO()
-      self.writexml(writer, "", indent, newl)
-      return writer.getvalue()
+        # indent = the indentation string to prepend, per level
+        # newl = the newline string to append
+        writer = _get_StringIO()
+        self.writexml(writer, "", indent, newl)
+        return writer.getvalue()
 
     def hasChildNodes(self):
         if self.childNodes:
@@ -794,6 +794,7 @@ def createProcessingInstruction(self, target, data):
     def createAttribute(self, qName):
         a = Attr(qName)
         a.ownerDocument = self
+        a.value = ""
         return a
 
     def createElementNS(self, namespaceURI, qualifiedName):
@@ -806,6 +807,7 @@ def createAttributeNS(self, namespaceURI, qualifiedName):
         prefix, localName = _nssplit(qualifiedName)
         a = Attr(qualifiedName, namespaceURI, localName, prefix)
         a.ownerDocument = self
+        a.value = ""
         return a
 
     def getElementsByTagNameNS(self, namespaceURI, localName):
