unicode_writer: don't force inline when it is not necessary

vstinner · vstinner · commit d0dba6eee8a2 · 2012-05-04T01:19:15.000+02:00
Keep inline for performance critical functions (functions used in loops)
diff --git a/Objects/unicodeobject.c b/Objects/unicodeobject.c
@@ -13665,7 +13665,7 @@ unicode_writer_update(unicode_writer_t *writer)
     writer->kind = PyUnicode_KIND(writer->buffer);
 }
 
-Py_LOCAL_INLINE(int)
+Py_LOCAL(int)
 unicode_writer_init(unicode_writer_t *writer,
                     Py_ssize_t length, Py_UCS4 maxchar)
 {
@@ -13762,7 +13762,7 @@ unicode_writer_write_char(
     return 0;
 }
 
-Py_LOCAL_INLINE(PyObject *)
+Py_LOCAL(PyObject *)
 unicode_writer_finish(unicode_writer_t *writer)
 {
     if (PyUnicode_Resize(&writer->buffer, writer->pos) < 0) {
@@ -13772,7 +13772,7 @@ unicode_writer_finish(unicode_writer_t *writer)
     return writer->buffer;
 }
 
-Py_LOCAL_INLINE(void)
+Py_LOCAL(void)
 unicode_writer_dealloc(unicode_writer_t *writer)
 {
     Py_CLEAR(writer->buffer);

Original file line number	Diff line number	Diff line change
`@@ -13665,7 +13665,7 @@ unicode_writer_update(unicode_writer_t *writer)`
`13665`	`13665`	`writer->kind = PyUnicode_KIND(writer->buffer);`
`13666`	`13666`	`}`
`13667`	`13667`
`13668`		`-Py_LOCAL_INLINE(int)`
	`13668`	`+Py_LOCAL(int)`
`13669`	`13669`	`unicode_writer_init(unicode_writer_t *writer,`
`13670`	`13670`	`Py_ssize_t length, Py_UCS4 maxchar)`
`13671`	`13671`	`{`
`@@ -13762,7 +13762,7 @@ unicode_writer_write_char(`
`13762`	`13762`	`return 0;`
`13763`	`13763`	`}`
`13764`	`13764`
`13765`		`-Py_LOCAL_INLINE(PyObject *)`
	`13765`	`+Py_LOCAL(PyObject *)`
`13766`	`13766`	`unicode_writer_finish(unicode_writer_t *writer)`
`13767`	`13767`	`{`
`13768`	`13768`	`if (PyUnicode_Resize(&writer->buffer, writer->pos) < 0) {`
`@@ -13772,7 +13772,7 @@ unicode_writer_finish(unicode_writer_t *writer)`
`13772`	`13772`	`return writer->buffer;`
`13773`	`13773`	`}`
`13774`	`13774`
`13775`		`-Py_LOCAL_INLINE(void)`
	`13775`	`+Py_LOCAL(void)`
`13776`	`13776`	`unicode_writer_dealloc(unicode_writer_t *writer)`
`13777`	`13777`	`{`
`13778`	`13778`	`Py_CLEAR(writer->buffer);`