Leak fix from Michael Hudson. Fix memory leak when dialect doesn't

Skip Montanaro · Skip Montanaro · commit d60fbd469ea0 · 2005-06-15T01:33:30.000Z
validate. Closes 1220242.
diff --git a/Modules/_csv.c b/Modules/_csv.c
@@ -416,7 +416,9 @@ dialect_new(PyTypeObject *type, PyObject *args, PyObject *kwargs)
 	}
 
 	ret = (PyObject *)self;
+	Py_INCREF(self);
 err:
+	Py_XDECREF(self);
 	Py_XDECREF(dialect);
 	Py_XDECREF(delimiter);
 	Py_XDECREF(doublequote);

Original file line number	Diff line number	Diff line change
`@@ -416,7 +416,9 @@ dialect_new(PyTypeObject type, PyObject args, PyObject *kwargs)`
`416`	`416`	`}`
`417`	`417`
`418`	`418`	`ret = (PyObject *)self;`
	`419`	`+ Py_INCREF(self);`
`419`	`420`	`err:`
	`421`	`+ Py_XDECREF(self);`
`420`	`422`	`Py_XDECREF(dialect);`
`421`	`423`	`Py_XDECREF(delimiter);`
`422`	`424`	`Py_XDECREF(doublequote);`