Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit d8e1c9e

Browse files
committed
Add "gi_" (generator-iterator) prefix to names of genobject members.
Makes it much easier to find references via dumb editor search (former "frame" in particular was near-hopeless).
1 parent ee13dba commit d8e1c9e

1 file changed

Lines changed: 13 additions & 9 deletions

File tree

Python/ceval.c

Lines changed: 13 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -111,8 +111,12 @@ staticforward PyTypeObject gentype;
111111

112112
typedef struct {
113113
PyObject_HEAD
114-
PyFrameObject *frame;
115-
int running; /* true if generator is being executed */
114+
/* The gi_ prefix is intended to remind of generator-iterator. */
115+
116+
PyFrameObject *gi_frame;
117+
118+
/* True if generator is being executed. */
119+
int gi_running;
116120
} genobject;
117121

118122
static PyObject *
@@ -123,26 +127,26 @@ gen_new(PyFrameObject *f)
123127
Py_DECREF(f);
124128
return NULL;
125129
}
126-
gen->frame = f;
127-
gen->running = 0;
130+
gen->gi_frame = f;
131+
gen->gi_running = 0;
128132
return (PyObject *)gen;
129133
}
130134

131135
static void
132136
gen_dealloc(genobject *gen)
133137
{
134-
Py_DECREF(gen->frame);
138+
Py_DECREF(gen->gi_frame);
135139
PyObject_DEL(gen);
136140
}
137141

138142
static PyObject *
139143
gen_iternext(genobject *gen)
140144
{
141145
PyThreadState *tstate = PyThreadState_GET();
142-
PyFrameObject *f = gen->frame;
146+
PyFrameObject *f = gen->gi_frame;
143147
PyObject *result;
144148

145-
if (gen->running) {
149+
if (gen->gi_running) {
146150
PyErr_SetString(PyExc_ValueError,
147151
"generator already executing");
148152
return NULL;
@@ -156,9 +160,9 @@ gen_iternext(genobject *gen)
156160
assert(f->f_back == NULL);
157161
f->f_back = tstate->frame;
158162

159-
gen->running = 1;
163+
gen->gi_running = 1;
160164
result = eval_frame(f);
161-
gen->running = 0;
165+
gen->gi_running = 0;
162166

163167
/* Don't keep the reference to f_back any longer than necessary. It
164168
* may keep a chain of frames alive or it could create a reference

0 commit comments

Comments
 (0)