bpo-41162: Clear audit hooks later during finalization (GH-21222)

zkonge · web-flow · commit daa0fe03a517 · 2020-07-03T22:06:46.000+01:00
diff --git a/Lib/test/audit-tests.py b/Lib/test/audit-tests.py
@@ -44,28 +44,6 @@ def __call__(self, event, args):
             raise self.exc_type("saw event " + event)
 
 
-class TestFinalizeHook:
-    """Used in the test_finalize_hooks function to ensure that hooks
-    are correctly cleaned up, that they are notified about the cleanup,
-    and are unable to prevent it.
-    """
-
-    def __init__(self):
-        print("Created", id(self), file=sys.stdout, flush=True)
-
-    def __call__(self, event, args):
-        # Avoid recursion when we call id() below
-        if event == "builtins.id":
-            return
-
-        print(event, id(self), file=sys.stdout, flush=True)
-
-        if event == "cpython._PySys_ClearAuditHooks":
-            raise RuntimeError("Should be ignored")
-        elif event == "cpython.PyInterpreterState_Clear":
-            raise RuntimeError("Should be ignored")
-
-
 # Simple helpers, since we are not in unittest here
 def assertEqual(x, y):
     if x != y:
@@ -128,10 +106,6 @@ def test_block_add_hook_baseexception():
                 pass
 
 
-def test_finalize_hooks():
-    sys.addaudithook(TestFinalizeHook())
-
-
 def test_pickle():
     import pickle
 
diff --git a/Lib/test/test_audit.py b/Lib/test/test_audit.py
@@ -51,22 +51,6 @@ def test_block_add_hook(self):
     def test_block_add_hook_baseexception(self):
         self.do_test("test_block_add_hook_baseexception")
 
-    def test_finalize_hooks(self):
-        returncode, events, stderr = self.run_python("test_finalize_hooks")
-        if stderr:
-            print(stderr, file=sys.stderr)
-        if returncode:
-            self.fail(stderr)
-
-        firstId = events[0][2]
-        self.assertSequenceEqual(
-            [
-                ("Created", " ", firstId),
-                ("cpython._PySys_ClearAuditHooks", " ", firstId),
-            ],
-            events,
-        )
-
     def test_pickle(self):
         support.import_module("pickle")
 
diff --git a/Misc/NEWS.d/next/Security/2020-07-03-20-41-29.bpo-41162.tb8pVj.rst b/Misc/NEWS.d/next/Security/2020-07-03-20-41-29.bpo-41162.tb8pVj.rst
@@ -0,0 +1 @@
+Audit hooks are now cleared later during finalization to avoid missing events.
diff --git a/Programs/_testembed.c b/Programs/_testembed.c
@@ -1112,8 +1112,11 @@ static int test_open_code_hook(void)
     return result;
 }
 
+static int _audit_hook_clear_count = 0;
+
 static int _audit_hook(const char *event, PyObject *args, void *userdata)
 {
+    assert(args && PyTuple_CheckExact(args));
     if (strcmp(event, "_testembed.raise") == 0) {
         PyErr_SetString(PyExc_RuntimeError, "Intentional error");
         return -1;
@@ -1122,6 +1125,8 @@ static int _audit_hook(const char *event, PyObject *args, void *userdata)
             return -1;
         }
         return 0;
+    } else if (strcmp(event, "cpython._PySys_ClearAuditHooks") == 0) {
+        _audit_hook_clear_count += 1;
     }
     return 0;
 }
@@ -1167,6 +1172,9 @@ static int test_audit(void)
 {
     int result = _test_audit(42);
     Py_Finalize();
+    if (_audit_hook_clear_count != 1) {
+        return 0x1000 | _audit_hook_clear_count;
+    }
     return result;
 }
 
diff --git a/Python/pylifecycle.c b/Python/pylifecycle.c
@@ -1291,6 +1291,13 @@ finalize_interp_clear(PyThreadState *tstate)
         _PyGC_CollectNoFail();
     }
 
+    /* Clear all loghooks */
+    /* Both _PySys_Audit function and users still need PyObject, such as tuple.
+       Call _PySys_ClearAuditHooks when PyObject available. */
+    if (is_main_interp) {
+        _PySys_ClearAuditHooks(tstate);
+    }
+
     _PyGC_Fini(tstate);
 
     if (is_main_interp) {
@@ -1405,9 +1412,6 @@ Py_FinalizeEx(void)
      */
     _PyGC_CollectIfEnabled();
 
-    /* Clear all loghooks */
-    _PySys_ClearAuditHooks(tstate);
-
     /* Destroy all modules */
     _PyImport_Cleanup(tstate);
 

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+Audit hooks are now cleared later during finalization to avoid missing events.`
Original file line number	Diff line number	Diff line change
`@@ -1112,8 +1112,11 @@ static int test_open_code_hook(void)`
`1112`	`1112`	`return result;`
`1113`	`1113`	`}`
`1114`	`1114`
	`1115`	`+static int _audit_hook_clear_count = 0;`
	`1116`	`+`
`1115`	`1117`	`static int _audit_hook(const char event, PyObject args, void *userdata)`
`1116`	`1118`	`{`
	`1119`	`+ assert(args && PyTuple_CheckExact(args));`
`1117`	`1120`	`if (strcmp(event, "_testembed.raise") == 0) {`
`1118`	`1121`	`PyErr_SetString(PyExc_RuntimeError, "Intentional error");`
`1119`	`1122`	`return -1;`
`@@ -1122,6 +1125,8 @@ static int _audit_hook(const char event, PyObject args, void *userdata)`
`1122`	`1125`	`return -1;`
`1123`	`1126`	`}`
`1124`	`1127`	`return 0;`
	`1128`	`+ } else if (strcmp(event, "cpython._PySys_ClearAuditHooks") == 0) {`
	`1129`	`+ _audit_hook_clear_count += 1;`
`1125`	`1130`	`}`
`1126`	`1131`	`return 0;`
`1127`	`1132`	`}`
`@@ -1167,6 +1172,9 @@ static int test_audit(void)`
`1167`	`1172`	`{`
`1168`	`1173`	`int result = _test_audit(42);`
`1169`	`1174`	`Py_Finalize();`
	`1175`	`+ if (_audit_hook_clear_count != 1) {`
	`1176`	`+ return 0x1000 \| _audit_hook_clear_count;`
	`1177`	`+ }`
`1170`	`1178`	`return result;`
`1171`	`1179`	`}`
`1172`	`1180`