Don't fail on importing things with undefined references. Unfortunately we

jackjansen · jackjansen · commit e3d7622fb3e5 · 2001-12-06T22:58:56.000Z
still fail on importing modules that link with libraries that fail
their initialization code (such as windowing libraries when we don't have
access to the window server) and that is what I really wanted to fix.
diff --git a/Python/dynload_next.c b/Python/dynload_next.c
@@ -148,7 +148,8 @@ dl_funcptr _PyImport_GetDynLoadFunc(const char *fqname, const char *shortname,
 			break;
 		}
 		if (errString == NULL) {
-			newModule = NSLinkModule(image, pathname, TRUE);
+			newModule = NSLinkModule(image, pathname,
+				NSLINKMODULE_OPTION_BINDNOW|NSLINKMODULE_OPTION_RETURN_ON_ERROR);
 			if (!newModule)
 				errString = "Failure linking new module";
 		}

Original file line number	Diff line number	Diff line change
`@@ -148,7 +148,8 @@ dl_funcptr _PyImport_GetDynLoadFunc(const char fqname, const char shortname,`
`148`	`148`	`break;`
`149`	`149`	`}`
`150`	`150`	`if (errString == NULL) {`
`151`		`- newModule = NSLinkModule(image, pathname, TRUE);`
	`151`	`+ newModule = NSLinkModule(image, pathname,`
	`152`	`+ NSLINKMODULE_OPTION_BINDNOW\|NSLINKMODULE_OPTION_RETURN_ON_ERROR);`
`152`	`153`	`if (!newModule)`
`153`	`154`	`errString = "Failure linking new module";`
`154`	`155`	`}`