fix strncpy call (uninitialized memory read)

gvanrossum · gvanrossum · commit ec4982761bb7 · 1995-01-20T16:59:12.000Z
diff --git a/Parser/parsetok.c b/Parser/parsetok.c
@@ -168,7 +168,8 @@ parsetok(tok, g, start, err_ret)
 			int len = tok->inp - tok->buf;
 			err_ret->text = malloc(len + 1);
 			if (err_ret->text != NULL) {
-				strncpy(err_ret->text, tok->buf, len+1);
+				if (len > 0)
+					strncpy(err_ret->text, tok->buf, len);
 				err_ret->text[len] = '\0';
 			}
 		}

Original file line number	Diff line number	Diff line change
`@@ -168,7 +168,8 @@ parsetok(tok, g, start, err_ret)`
`168`	`168`	`int len = tok->inp - tok->buf;`
`169`	`169`	`err_ret->text = malloc(len + 1);`
`170`	`170`	`if (err_ret->text != NULL) {`
`171`		`- strncpy(err_ret->text, tok->buf, len+1);`
	`171`	`+ if (len > 0)`
	`172`	`+ strncpy(err_ret->text, tok->buf, len);`
`172`	`173`	`err_ret->text[len] = '\0';`
`173`	`174`	`}`
`174`	`175`	`}`