Generate FOR_ITER-based loops instead of old FOR_LOOP-based loops

jeremyhylton · jeremyhylton · commit f354575328be · 2001-08-28T16:35:18.000Z
diff --git a/Lib/compiler/pycodegen.py b/Lib/compiler/pycodegen.py
@@ -355,11 +355,11 @@ def visitFor(self, node):
         self.set_lineno(node)
         self.emit('SETUP_LOOP', after)
         self.visit(node.list)
-        self.visit(ast.Const(0))
+        self.emit('GET_ITER')
+
         self.nextBlock(start)
         self.set_lineno(node, force=1)
-        self.emit('FOR_LOOP', anchor)
-        self.nextBlock()
+        self.emit('FOR_ITER', anchor)
         self.visit(node.assign)
         self.visit(node.body)
         self.emit('JUMP_ABSOLUTE', start)
@@ -567,7 +567,8 @@ def visitTryExcept(self, node):
                 self.nextBlock(next)
             else:
                 self.nextBlock()
-            self.emit('POP_TOP')
+            if expr: # XXX
+                self.emit('POP_TOP')
         self.emit('END_FINALLY')
         if node.else_:
             self.nextBlock(lElse)
@@ -1001,7 +1002,10 @@ def _nameOp(self, prefix, name):
             else:
                 self.emit(prefix + '_FAST', name)
         elif scope == SC_GLOBAL:
-            self.emit(prefix + '_GLOBAL', name)
+            if not self.optimized:
+                self.emit(prefix + '_NAME', name)
+            else:
+                self.emit(prefix + '_GLOBAL', name)
         elif scope == SC_FREE or scope == SC_CELL:
             self.emit(prefix + '_DEREF', name)
         else:
diff --git a/Tools/compiler/compiler/pycodegen.py b/Tools/compiler/compiler/pycodegen.py
@@ -355,11 +355,11 @@ def visitFor(self, node):
         self.set_lineno(node)
         self.emit('SETUP_LOOP', after)
         self.visit(node.list)
-        self.visit(ast.Const(0))
+        self.emit('GET_ITER')
+
         self.nextBlock(start)
         self.set_lineno(node, force=1)
-        self.emit('FOR_LOOP', anchor)
-        self.nextBlock()
+        self.emit('FOR_ITER', anchor)
         self.visit(node.assign)
         self.visit(node.body)
         self.emit('JUMP_ABSOLUTE', start)
@@ -567,7 +567,8 @@ def visitTryExcept(self, node):
                 self.nextBlock(next)
             else:
                 self.nextBlock()
-            self.emit('POP_TOP')
+            if expr: # XXX
+                self.emit('POP_TOP')
         self.emit('END_FINALLY')
         if node.else_:
             self.nextBlock(lElse)
@@ -1001,7 +1002,10 @@ def _nameOp(self, prefix, name):
             else:
                 self.emit(prefix + '_FAST', name)
         elif scope == SC_GLOBAL:
-            self.emit(prefix + '_GLOBAL', name)
+            if not self.optimized:
+                self.emit(prefix + '_NAME', name)
+            else:
+                self.emit(prefix + '_GLOBAL', name)
         elif scope == SC_FREE or scope == SC_CELL:
             self.emit(prefix + '_DEREF', name)
         else:
