Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Commit f730fc3

Browse files
committed
Be a little more careful to avoid including style information in the
generated markup. Don't be careless with the navigation icons! We should use the blank icon where there is not anyplace to go for a particular position in the navigation bar.
1 parent 3eb7c12 commit f730fc3

1 file changed

Lines changed: 12 additions & 13 deletions

File tree

Doc/perl/l2hinit.perl

Lines changed: 12 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -18,6 +18,7 @@ package main;
1818
$SHOW_SECTION_NUMBERS = 1;
1919

2020
$ICONSERVER = '../icons';
21+
$IMAGE_TYPE = 'gif';
2122

2223
# Control where the navigation bars should show up:
2324
$TOP_NAVIGATION = 1;
@@ -93,7 +94,6 @@ sub custom_driver_hook {
9394

9495

9596
$CUSTOM_BUTTONS = '';
96-
$NAV_BGCOLOR = " bgcolor=\"#99CCFF\"";
9797

9898
sub make_nav_sectref {
9999
my($label,$title) = @_;
@@ -111,22 +111,22 @@ sub make_my_icon {
111111
. " height=\"32\"\n alt=\"$text\" width=\"32\">";
112112
}
113113

114-
$BLANK_ICON = make_my_icon("blank", "");
114+
$BLANK_ICON = make_my_icon('blank', '');
115115

116116
@my_icons = ();
117117
$my_icons{'next_page_inactive'} = $BLANK_ICON;
118118
$my_icons{'previous_page_inactive'} = $BLANK_ICON;
119119
$my_icons{'up_page_inactive'} = $BLANK_ICON;
120-
$x = make_my_icon("next", "Next Page");
120+
$x = make_my_icon('next', 'Next Page');
121121
$my_icons{'next_page'} = $x;
122122
$my_icons{'next'} = $x;
123-
$x = make_my_icon("previous", "Previous Page");
123+
$x = make_my_icon('previous', 'Previous Page');
124124
$my_icons{'previous_page'} = $x;
125125
$my_icons{'previous'} = $x;
126-
$my_icons{'up'} = make_my_icon("up", "Up One Level");
127-
$my_icons{'contents'} = make_my_icon("contents", "Contents");
128-
$my_icons{'index'} = make_my_icon("index", "Index");
129-
$my_icons{'modules'} = make_my_icon("modules", "Module Index");
126+
$my_icons{'up'} = make_my_icon('up', 'Up One Level');
127+
$my_icons{'contents'} = make_my_icon('contents', 'Contents');
128+
$my_icons{'index'} = make_my_icon('index', 'Index');
129+
$my_icons{'modules'} = make_my_icon('modules', 'Module Index');
130130

131131

132132
sub use_my_icon {
@@ -137,9 +137,9 @@ sub use_my_icon {
137137

138138
sub make_nav_panel {
139139
my $s;
140-
$NEXT = use_my_icon("$NEXT");
141-
$UP = use_my_icon("$UP");
142-
$PREVIOUS = use_my_icon("$PREVIOUS");
140+
$NEXT = $NEXT_TITLE ? use_my_icon("$NEXT") : $BLANK_ICON;
141+
$UP = $UP_TITLE ? use_my_icon("$UP") : $BLANK_ICON;
142+
$PREVIOUS = $PREVIOUS_TITLE ? use_my_icon("$PREVIOUS") : $BLANK_ICON;
143143
$CONTENTS = use_my_icon("$CONTENTS");
144144
$INDEX = $INDEX ? use_my_icon("$INDEX") : $BLANK_ICON;
145145
if (!$CUSTOM_BUTTONS) {
@@ -152,8 +152,7 @@ sub make_nav_panel {
152152
. "\n<td>$UP</td>"
153153
. "\n<td>$NEXT</td>"
154154
# title box
155-
. "\n<td align=\"center\"$NAV_BGCOLOR width=\"100%\">"
156-
. "\n <b class=\"title\">$t_title</b></td>"
155+
. "\n<td align=\"center\" width=\"100%\">$t_title</td>"
157156
# right-hand side
158157
. "\n<td>$CONTENTS</td>"
159158
. "\n<td>$CUSTOM_BUTTONS</td>" # module index

0 commit comments

Comments
 (0)