approximately double dump performance by moving import of cgi.escape back to

Skip Montanaro · Skip Montanaro · commit fbacaf7298fe · 2001-10-01T17:50:29.000Z
top level.
diff --git a/Lib/xmlrpclib.py b/Lib/xmlrpclib.py
@@ -136,6 +136,7 @@
 
 import re, string, time, operator
 from types import *
+from cgi import escape as _escape
 
 try:
     unicode
@@ -472,15 +473,13 @@ def dump_double(self, value):
     dispatch[FloatType] = dump_double
 
     def dump_string(self, value):
-        from cgi import escape
-        self.write("<value><string>%s</string></value>\n" % escape(value))
+        self.write("<value><string>%s</string></value>\n" % _escape(value))
     dispatch[StringType] = dump_string
 
     if unicode:
         def dump_unicode(self, value):
             value = value.encode(self.encoding)
-            from cgi import escape
-            self.write("<value><string>%s</string></value>\n" % escape(value))
+            self.write("<value><string>%s</string></value>\n" % _escape(value))
         dispatch[UnicodeType] = dump_unicode
 
     def container(self, value):
@@ -513,8 +512,7 @@ def dump_struct(self, value):
             write("<member>\n")
             if type(k) is not StringType:
                 raise TypeError, "dictionary key must be string"
-            from cgi import escape
-            write("<name>%s</name>\n" % escape(k))
+            write("<name>%s</name>\n" % _escape(k))
             self.__dump(v)
             write("</member>\n")
         write("</struct></value>\n")
