Arrange for PyErr_CheckSignals() to be called via Py_AddPendingCall().

gvanrossum · gvanrossum · commit fcdd0e40a45d · 1997-01-21T06:13:09.000Z
This avoids having to call sigcheck() (the same routine by its old
name :-) in the ticker code in ceval.c's main interpreter loop.
diff --git a/Modules/signalmodule.c b/Modules/signalmodule.c
@@ -115,6 +115,7 @@ signal_handler(sig_num)
 #endif
 		is_tripped++;
 		Handlers[sig_num].tripped = 1;
+		Py_AddPendingCall((int (*) Py_PROTO((ANY *)))PyErr_CheckSignals, NULL);
 #ifdef WITH_THREAD
 	}
 #endif
@@ -523,7 +524,7 @@ PyErr_CheckSignals()
 				Py_DECREF(arglist);
 			}
 			if (!result)
-				return 1;
+				return -1;
 
 			Py_DECREF(result);
 		}
@@ -541,6 +542,7 @@ PyErr_SetInterrupt()
 {
 	is_tripped++;
 	Handlers[SIGINT].tripped = 1;
+	Py_AddPendingCall((int (*) Py_PROTO((ANY *)))PyErr_CheckSignals, NULL);
 }
 
 void

Original file line number	Diff line number	Diff line change
`@@ -115,6 +115,7 @@ signal_handler(sig_num)`
`115`	`115`	`#endif`
`116`	`116`	`is_tripped++;`
`117`	`117`	`Handlers[sig_num].tripped = 1;`
	`118`	`+ Py_AddPendingCall((int () Py_PROTO((ANY )))PyErr_CheckSignals, NULL);`
`118`	`119`	`#ifdef WITH_THREAD`
`119`	`120`	`}`
`120`	`121`	`#endif`
`@@ -523,7 +524,7 @@ PyErr_CheckSignals()`
`523`	`524`	`Py_DECREF(arglist);`
`524`	`525`	`}`
`525`	`526`	`if (!result)`
`526`		`- return 1;`
	`527`	`+ return -1;`
`527`	`528`
`528`	`529`	`Py_DECREF(result);`
`529`	`530`	`}`
`@@ -541,6 +542,7 @@ PyErr_SetInterrupt()`
`541`	`542`	`{`
`542`	`543`	`is_tripped++;`
`543`	`544`	`Handlers[SIGINT].tripped = 1;`
	`545`	`+ Py_AddPendingCall((int () Py_PROTO((ANY )))PyErr_CheckSignals, NULL);`
`544`	`546`	`}`
`545`	`547`
`546`	`548`	`void`