-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
Use proper markup for the C "constants" #106919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Jul 20, 2023
serhiy-storchaka
added a commit
that referenced
this issue
Jul 21, 2023
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Jul 21, 2023
…stants" (pythonGH-106920). (cherry picked from commit fcc816d) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Jul 21, 2023
…stants" (pythonGH-106920). (cherry picked from commit fcc816d) Co-authored-by: Serhiy Storchaka <[email protected]>
serhiy-storchaka
added a commit
that referenced
this issue
Jul 21, 2023
serhiy-storchaka
added a commit
that referenced
this issue
Jul 21, 2023
Are you aware of the discussion in #96996? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Many of the C "constants" (actually macros without parameters) are declared in the documentation using the
data
directive and referred using:data:
and:const:
roles. It is incorrect, because these directive and roles are defined in the Python domain and purposed to use with Python module level variables. I think that it is better to document them as they are, the C macros.One of the differences is that the HTML anchors contains the
c.
prefix, e.g.c.METH_VARARGS
. There may also be the difference in visual representation.Other issues in the current markup:
METH_KEYWORDS
andMETH_METHOD
and they cannot be referred.Py_TPFLAGS_HAVE_GC
. They does not conflict only because they are in different namespaces.Linked PRs
The text was updated successfully, but these errors were encountered: