Thanks to visit codestin.com
Credit goes to github.com

Skip to content

_PyFrame_GetState is misnamed and does more than it needs to #108991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
iritkatriel opened this issue Sep 6, 2023 · 0 comments · Fixed by #108992
Closed

_PyFrame_GetState is misnamed and does more than it needs to #108991

iritkatriel opened this issue Sep 6, 2023 · 0 comments · Fixed by #108992
Assignees
@iritkatriel
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)

Comments

@iritkatriel
Copy link
Member

iritkatriel commented Sep 6, 2023 •
edited by bedevere-bot
Loading

_PyFrame_GetState is a static function so can be renamed to reflect that.

More importantly, it calculates a lot more than what it is actually used for (it is called in two places, each of which checks for one of the states: CLEARED or SUSPENDED). The rest is neither used nor tested.

Some of the other states that this function checks for depend on the opcode at prev_instr, which is going to be replaced soon by instr_ptr. If we want to keep this function working we need to first cover all the states by tests. But there is no point doing this for code which is unused.

So I will replace this function by two simpler functions for the two existing use cases: checking if the frame is in CLEARED or SUSPENDED state.

Linked PRs
@iritkatriel iritkatriel self-assigned this Sep 6, 2023
@iritkatriel iritkatriel added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Sep 6, 2023
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Sep 6, 2023
@iritkatriel
pythongh-108991: replace _PyFrame_GetState by two simpler functions
4b5ce4d
iritkatriel added a commit to iritkatriel/cpython that referenced this issue Sep 6, 2023
@iritkatriel
pythongh-108991: replace _PyFrame_GetState by two simpler functions
bd3a0b1
@iritkatriel iritkatriel mentioned this issue Sep 6, 2023
Merged
iritkatriel added a commit that referenced this issue Sep 6, 2023
@iritkatriel
gh-108991: replace _PyFrame_GetState by two simpler functions (#108992)
39376cb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iritkatriel iritkatriel

Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gh-108991: replace _PyFrame_GetState by two simpler functions iritkatriel/cpython
1 participant
@iritkatriel