Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test_b2a_roundtrip failure in test_binascii.py #109418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
colesbury opened this issue Sep 14, 2023 · 1 comment
Closed

test_b2a_roundtrip failure in test_binascii.py #109418

colesbury opened this issue Sep 14, 2023 · 1 comment
Labels
3.13 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error

Comments

@colesbury
Copy link
Contributor

colesbury commented Sep 14, 2023 •
edited by bedevere-app bot
Loading

Bug report

Bug description:

Seen in GitHub CI:

======================================================================
ERROR: test_b2a_roundtrip (test.test_binascii.BytearrayBinASCIITest.test_b2a_roundtrip)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_binascii.py", line 233, in test_b2a_roundtrip
    binary=hypothesis.strategies.binary(),
           ^^^^^^^
  File "/home/runner/work/cpython/cpython-builddir/hypovenv/lib/python3.13/site-packages/hypothesis/core.py", line 1386, in wrapped_test
    raise the_error_hypothesis_found
  File "/home/runner/work/cpython/cpython-ro-srcdir/Lib/test/test_binascii.py", line 237, in test_b2a_roundtrip
    converted = binascii.b2a_uu(self.type2test(binary), backtick=backtick)
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
binascii.Error: At most 45 bytes at once
Falsifying example: test_b2a_roundtrip(
    self=<test.test_binascii.BytearrayBinASCIITest testMethod=test_b2a_roundtrip>,
    binary=b'\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00\x00',
    backtick=False,
)

You can reproduce this example by temporarily adding @reproduce_failure('6.84.0', b'AXicY2RgYBwciIEBAA2TAC8=') as a decorator on your test case

(https://github.com/python/cpython/actions/runs/6189137441/job/16802618181?pr=109344)

I think we need a max_size=45 in:

cpython/Lib/test/test_binascii.py

Lines 232 to 239 in 3b9d10b

@hypothesis.given(
binary=hypothesis.strategies.binary(),
backtick=hypothesis.strategies.booleans(),
)
def test_b2a_roundtrip(self, binary, backtick):
converted = binascii.b2a_uu(self.type2test(binary), backtick=backtick)
restored = binascii.a2b_uu(self.type2test(converted))
self.assertConversion(binary, converted, restored, backtick=backtick)

cc @sobolevn

CPython versions tested on:

CPython main branch

Operating systems tested on:

Linux

Linked PRs
@colesbury colesbury added type-bug An unexpected behavior, bug, or error tests Tests in the Lib/test dir 3.13 bugs and security fixes labels Sep 14, 2023
@hugovk
Copy link
Member

hugovk commented Sep 14, 2023

This was added in #107863, cc @sobolevn.

sobolevn added a commit to sobolevn/cpython that referenced this issue Sep 14, 2023
@sobolevn
pythongh-109418: Fix hypothesis strategy for b2a_roundtrip test
d95b355
@bedevere-app bedevere-app bot mentioned this issue Sep 14, 2023
Merged
hugovk pushed a commit that referenced this issue Sep 14, 2023
@sobolevn
gh-109418: Fix hypothesis strategy for b2a_roundtrip test (#109419)
d7dc3d9
@hugovk hugovk closed this as completed Sep 14, 2023
@hugovk hugovk mentioned this issue Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes tests Tests in the Lib/test dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@colesbury @hugovk