-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
PyThreadState_DeleteCurrent
documentation incorrect
#115145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
Comments
corona10
added a commit
to corona10/cpython
that referenced
this issue
Oct 3, 2024
corona10
added a commit
that referenced
this issue
Oct 3, 2024
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Oct 3, 2024
…rent`` (pythongh-124920) (cherry picked from commit 9eeb21b) Co-authored-by: Donghee Na <[email protected]>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this issue
Oct 3, 2024
…rent`` (pythongh-124920) (cherry picked from commit 9eeb21b) Co-authored-by: Donghee Na <[email protected]>
This was referenced Oct 3, 2024
Let's close this issue cc @colesbury |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
The documentation for
PyThreadState_DeleteCurrent()
says:However, calling the function without holding the GIL results in a fatal Python error:
It looks to me like like CPython code since at least 3.8 required holding the GIL when calling
PyThreadState_DeleteCurrent()
, so I think we should update the documentation rather than change the implementation.Linked PRs
PyThreadState_DeleteCurrent
#124920PyThreadState_DeleteCurrent
(gh-124920) #124930PyThreadState_DeleteCurrent
(gh-124920) #124931The text was updated successfully, but these errors were encountered: