Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Prevent non-source files from being added into source-only directories #118189

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arhadthedev opened this issue Apr 23, 2024 · 1 comment
Closed

Prevent non-source files from being added into source-only directories #118189

arhadthedev opened this issue Apr 23, 2024 · 1 comment
Labels
3.13 bugs and security fixes type-feature A feature request or enhancement

Comments

@arhadthedev
Copy link
Member

arhadthedev commented Apr 23, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

gh-118159 accidentally added Include/incl.tar with a full copy of Include. Since this addition fell through the cracks, we need to help both contributors and triagers by .gitignore-ing non-source files in the most edited directories:

  • anything different from *.h in Include
  • anything different from *.py in Lib (except Lib/test where code is bundled with test data)

Modules and Objects require more complex rules so I skipped them. However, it'll be great if anyone defines and adds them.

Has this already been discussed elsewhere?

No response given

Links to previous discussion of this feature:

No response

Linked PRs
@arhadthedev arhadthedev added type-feature A feature request or enhancement 3.13 bugs and security fixes labels Apr 23, 2024
@bedevere-app bedevere-app bot mentioned this issue Apr 23, 2024
Merged
@JelleZijlstra
Copy link
Member

I don't think it's worth adding automated rules here. Adding such rules has a cost in that it can cause confusion when a future change relies on adding files that don't match the pattern we expect. And the benefit is low because it's rare that we accidentally add files and if we do, we can easily fix the mistake later.

JelleZijlstra pushed a commit that referenced this issue Apr 23, 2024
@arhadthedev
gh-118189: Revert accidentally added incl.tar (#118190)
2584082
@arhadthedev arhadthedev closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.13 bugs and security fixes type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JelleZijlstra @arhadthedev