Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add INSTRUCTION_SIZE macro to code generator. #118423

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
markshannon opened this issue Apr 30, 2024 · 1 comment
Closed

Add INSTRUCTION_SIZE macro to code generator. #118423

markshannon opened this issue Apr 30, 2024 · 1 comment
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement

Comments

@markshannon
Copy link
Member

markshannon commented Apr 30, 2024 •
edited by bedevere-app bot
Loading

In bytecodes.c we use both next_instr - this_instr and 1 + INLINE_CACHE_ENTRIES_... to mean "instruction length".
We should add a macro for the purpose that is understood by the code generator.

Examples

The somewhat confusing LOAD_IP(1 + INLINE_CACHE_ENTRIES_SEND); would become LOAD_IP(INSTRUCTION_LENGTH)

frame->return_offset = (uint16_t)(next_instr - this_instr); would become frame->return_offset = INSTRUCTION_LENGTH; which is both easier to understand and wouldn't be rejected as tier 2 code.

Linked PRs
@markshannon markshannon mentioned this issue Apr 30, 2024
Merged
@erlend-aasland erlend-aasland added the interpreter-core (Objects, Python, Grammar, and Parser dirs) label Apr 30, 2024
@bedevere-app bedevere-app bot mentioned this issue Oct 14, 2024
Merged
@picnixz picnixz added the type-feature A feature request or enhancement label Oct 14, 2024
markshannon pushed a commit that referenced this issue Oct 29, 2024
@tomasr8
gh-118423: Add INSTRUCTION_SIZE macro to code generator (GH-125467)
aab58a9
picnixz pushed a commit to picnixz/cpython that referenced this issue Dec 8, 2024
@tomasr8 @picnixz
pythongh-118423: Add INSTRUCTION_SIZE macro to code generator (pyth…
4e37dab 
…onGH-125467)
@Fidget-Spinner
Copy link
Member

I think this is done. So I'll close the issue.

ebonnal pushed a commit to ebonnal/cpython that referenced this issue Jan 12, 2025
@tomasr8 @ebonnal
pythongh-118423: Add INSTRUCTION_SIZE macro to code generator (pyth…
c3936cf 
…onGH-125467)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
interpreter-core (Objects, Python, Grammar, and Parser dirs) type-feature A feature request or enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@markshannon @picnixz @erlend-aasland @Fidget-Spinner