Clean up and microoptimize str.translate and charmap codec #122561
Labels
performance
Performance or resource usage
Comments
|
Do you plan to create a pull request? |
|
I thought that I already created a PR. Now I have to find where it went. |
serhiy-storchaka
added a commit
to serhiy-storchaka/cpython
that referenced
this issue
Aug 12, 2024
… codec * Replace PyLong_AS_LONG() with PyLong_AsLong(). * Call PyLong_AsLong() only once per the replacement code. * Use PyMapping_GetOptionalItem() instead of PyObject_GetItem().
serhiy-storchaka
added a commit
that referenced
this issue
Aug 28, 2024
…GH-122932) * Replace PyLong_AS_LONG() with PyLong_AsLong(). * Call PyLong_AsLong() only once per the replacement code. * Use PyMapping_GetOptionalItem() instead of PyObject_GetItem().
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Initially I just planned to get rid of
PyLong_AS_LONG(undocumented transitional alias ofPyLong_AsLong) inObjects/unicodeobject.c. But I have used opportunity to add few optimizations in the nearby code. I do not expect significant performance boost, but some overhead was removed in specific corner cases:PyLong_AsLongAndOverflowis now only called once for the replacement code (PyLong_AS_LONGwas called twice).PyMapping_GetOptionalIteminstead ofPyObject_GetItemallows to avoid raising aKeyErrorif the translation table is adict. I left this case in previous round (Add PyMapping_GetOptionalItem() #106307) because this does not make the code simpler (we still need to handle otherLookupError), but it still has a tiny performance benefit.Linked PRs
The text was updated successfully, but these errors were encountered: