gh-122561: Clean up and microoptimize str.translate and charmap codec #122932
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… codec * Replace PyLong_AS_LONG() with PyLong_AsLong(). * Call PyLong_AsLong() only once per the replacement code. * Use PyMapping_GetOptionalItem() instead of PyObject_GetItem().
vstinner
reviewed
Aug 27, 2024
| @@ -8935,15 +8946,20 @@ unicode_translate_call_errorhandler(const char *errors, | |||
| which must be decrefed by the caller. | |||
| Return 0 on success, -1 on error */ | |||
| static int | |||
| charmaptranslate_lookup(Py_UCS4 c, PyObject *mapping, PyObject **result) | |||
| charmaptranslate_lookup(Py_UCS4 c, PyObject *mapping, PyObject **result, Py_UCS4 *replace) | |||
There was a problem hiding this comment.
Can you explain in the comment when replace is set?
vstinner
approved these changes
Aug 28, 2024
| @@ -8594,7 +8606,7 @@ charmapencode_output(Py_UCS4 c, PyObject *mapping, | |||
| return enc_SUCCESS; | |||
| } | |||
|
|
|||
| rep = charmapencode_lookup(c, mapping); | |||
| rep = charmapencode_lookup(c, mapping, &replace); | |||
There was a problem hiding this comment.
You can move unsigned char replace; declaration here, to reduce the scope of the variable.
There was a problem hiding this comment.
I added it next to the declaration of rep, as in all other cases.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.