Thanks to visit codestin.com
Credit goes to github.com

Skip to content

make distclean needs GNU make to work #122661

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
bibajz opened this issue Aug 4, 2024 · 0 comments
Closed

make distclean needs GNU make to work #122661

bibajz opened this issue Aug 4, 2024 · 0 comments
Labels
build The build process and cross-build docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error

Comments

@bibajz
Copy link
Contributor

bibajz commented Aug 4, 2024

Bug report

Bug description:

Introduced in bc37ac7 , define directive is GNU make specific - https://www.gnu.org/software/make/manual/html_node/Multi_002dLine.html

This is the output of me running make distclean on main, where make is of the BSD variant - https://man.freebsd.org/cgi/man.cgi?make(1)


$ make distclean
find . -depth -name '__pycache__' -exec rm -rf {} ';'
find . -name '*.py[co]' -exec rm -f {} ';'
find . -name '*.[oa]' -exec rm -f {} ';'
find . -name '*.s[ol]' -exec rm -f {} ';'
find . -name '*.so.[0-9]*.[0-9]*' -exec rm -f {} ';'
find . -name '*.lto' -exec rm -f {} ';'
find . -name '*.wasm' -exec rm -f {} ';'
find . -name '*.lst' -exec rm -f {} ';'
find build -name 'fficonfig.h' -exec rm -f {} ';' || true
find build -name '*.py' -exec rm -f {} ';' || true
find build -name '*.py[co]' -exec rm -f {} ';' || true
rm -f pybuilddir.txt
rm -f _bootstrap_python
rm -f python.html python*.js python.data python*.symbols python*.map
rm -f ./usr/local/lib/python3.14/os.py
rm -f Programs/_testembed Programs/_freeze_module
rm -rf Python/deepfreeze
rm -f Python/frozen_modules/*.h
rm -f Python/frozen_modules/MANIFEST
rm -f jit_stencils.h
find build -type f -a ! -name '*.gc??' -exec rm -f {} ';'
rm -f Include/pydtrace_probes.h
rm -f profile-gen-stamp
rm -rf iOS/testbed/Python.xcframework/ios-*/bin
rm -rf iOS/testbed/Python.xcframework/ios-*/lib
rm -rf iOS/testbed/Python.xcframework/ios-*/include
rm -rf iOS/testbed/Python.xcframework/ios-*/Python.framework
rm -f *.fdata
rm -f *.prebolt
rm -f *.bolt_inst
rm -f python libpython3.14.a libpython3.14.a   tags TAGS  config.cache config.log pyconfig.h Modules/config.c
rm -rf build platform
rm -rf no-framework
rm -rf iOS/Frameworks
rm -rf iOSTestbed.*
rm -f python-config.py python-config
rm -rf cross-build
make -C ./Doc clean
make[1]: "/tmp/forked/cpython/Doc/Makefile" line 243: Invalid line type
make[1]: "/tmp/forked/cpython/Doc/Makefile" line 249: Invalid line type
make[1]: Fatal errors encountered -- cannot continue
make[1]: stopped in /tmp/forked/cpython/Doc
*** Error code 1

Stop.
make: stopped in /tmp/forked/cpython

Here are the lines:

$ $ cat -n Doc/Makefile | tail -n +243 | head -n7
   243	define ensure_package
   244		if uv --version > /dev/null; then \
   245			$(VENVDIR)/bin/python3 -m $(1) --version > /dev/null || VIRTUAL_ENV=$(VENVDIR) uv pip install $(1); \
   246		else \
   247			$(VENVDIR)/bin/python3 -m $(1) --version > /dev/null || $(VENVDIR)/bin/python3 -m pip install $(1); \
   248		fi
   249	endef

Tested on: FreeBSD14.1

CPython versions tested on:

3.13, CPython main branch

Operating systems tested on:

Other

Linked PRs

@bibajz bibajz added the type-bug An unexpected behavior, bug, or error label Aug 4, 2024
@picnixz picnixz added the build The build process and cross-build label Aug 4, 2024
@hugovk hugovk added docs Documentation in the Doc dir build The build process and cross-build and removed build The build process and cross-build docs Documentation in the Doc dir labels Aug 4, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 4, 2024
miss-islington pushed a commit to miss-islington/cpython that referenced this issue Aug 4, 2024
hugovk pushed a commit that referenced this issue Aug 4, 2024
@hugovk hugovk closed this as completed Aug 4, 2024
hugovk pushed a commit that referenced this issue Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build The build process and cross-build docs Documentation in the Doc dir type-bug An unexpected behavior, bug, or error
Projects
None yet
Development

No branches or pull requests

3 participants