Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Turtle context managers for fill, poly and tracer #126349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yngvem opened this issue Nov 3, 2024 · 3 comments
Closed

Turtle context managers for fill, poly and tracer #126349

yngvem opened this issue Nov 3, 2024 · 3 comments
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement

Comments

@yngvem
Copy link
Contributor

yngvem commented Nov 3, 2024 •
edited by bedevere-app bot
Loading

Feature or enhancement

Proposal:

When I taught Python with Turtle, I always had to find other examples when I got to context managers. This is a shame, as there are several places in the Turtle module where context managers make sense. The most obvious places (in my opinion) are:

  • turtle.begin_fill() / turtle.end_fill()
  • turtle.begin_poly() / turtle.end_poly()
  • turtle.tracer(0) / turtle.tracer(1) (disable animations)

@MarieRoald and I plan to submit a PR about this shortly

Has this already been discussed elsewhere?

I have already discussed this feature proposal on Discourse

Links to previous discussion of this feature:

https://discuss.python.org/t/improving-the-turtle-library/61840

Linked PRs
@yngvem yngvem added the type-feature A feature request or enhancement label Nov 3, 2024
@bedevere-app bedevere-app bot mentioned this issue Nov 3, 2024
Merged
@picnixz picnixz added the stdlib Python modules in the Lib dir label Nov 8, 2024
@github-actions github-actions bot mentioned this issue Dec 1, 2024
Closed
erlend-aasland added a commit that referenced this issue Jan 18, 2025
@MarieRoald @yngvem
@hugovk @danielhollas @picnixz @erlend-aasland
gh-126349: Add 'fill', 'poly', and 'no_animation' context managers to…
d3adf02 
… turtle (#126350)

Co-authored-by: Marie Roald <[email protected]>
Co-authored-by: Yngve Mardal Moe <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Daniel Hollas <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
@erlend-aasland
Copy link
Contributor

Thanks for suggesting and implementing this!

@hugovk
Copy link
Member

hugovk commented Jan 19, 2025

Let's re-open to handle the reference leak: #126350 (comment).

@hugovk hugovk reopened this Jan 19, 2025
encukou added a commit to encukou/cpython that referenced this issue Jan 20, 2025
@encukou
pythongh-126349: test_turtle: Add cleanup to avoid reference leaks
1744d67
@bedevere-app bedevere-app bot mentioned this issue Jan 20, 2025
Merged
srinivasreddy pushed a commit to srinivasreddy/cpython that referenced this issue Jan 21, 2025
@MarieRoald @yngvem
@hugovk @danielhollas @picnixz @erlend-aasland @srinivasreddy
pythongh-126349: Add 'fill', 'poly', and 'no_animation' context manag…
2da0add 
…ers to turtle (python#126350)

Co-authored-by: Marie Roald <[email protected]>
Co-authored-by: Yngve Mardal Moe <[email protected]>
Co-authored-by: Hugo van Kemenade <[email protected]>
Co-authored-by: Daniel Hollas <[email protected]>
Co-authored-by: Bénédikt Tran <[email protected]>
Co-authored-by: Erlend E. Aasland <[email protected]>
encukou added a commit that referenced this issue Jan 21, 2025
@encukou
gh-126349: test_turtle: Add cleanup to avoid reference leaks (GH-129079)
bf150f6
@hugovk
Copy link
Member

hugovk commented Feb 27, 2025

Refleak fixed in #129079, thanks!

@hugovk hugovk closed this as completed Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stdlib Python modules in the Lib dir type-feature A feature request or enhancement
Projects
Turtle issues 🐢
Status: Done
Milestone
No milestone
Development

No branches or pull requests
4 participants
@hugovk @yngvem @picnixz @erlend-aasland