GH-100242: bring functools.py partial implementation more in line with C code #100244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in partial.__new__, before checking for the existence of the attribute 'func', first check whether the argument is an instance of partial.
✅ Deploy Preview for python-cpython-preview canceled.
|
AlexWaygood
reviewed
Dec 14, 2022
|
As a first approximation this looks good. In the next couple of days, I can devote some time to give it more thought. |
|
@rhettinger very gentle ping, would you maybe have some time to look into this PR? |
ambv
approved these changes
Apr 17, 2024
There was a problem hiding this comment.
The only risk I'm seeing here is the subtle change that now allows a subclass of functools.partial with an overriden __call__ whereas this would be rejected before in the C version.
As long as we accept this change for 3.13 alone, this is uncontroversial. As for whether this should land in 3.12.4, I'm leaving this question open. My intuition says it's fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in
partial.__new__, before checking for the existence of the attribute 'func', first check whether the argument is an instance of partial.