Thanks to visit codestin.com
Credit goes to github.com

Skip to content

GH-100126: Skip incomplete frames in more places #100613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 7 commits into from
Jan 9, 2023
Merged

GH-100126: Skip incomplete frames in more places #100613

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5f18200
Add a failing regression test
brandtbucher Dec 29, 2022
4ff833e
fixup
brandtbucher Dec 29, 2022
04b77ac
Add _PyFrame_GetComplete/_PyThreadState_GetFrame
brandtbucher Dec 29, 2022
41c70e6
Clean up how we access/walk the frame stack
brandtbucher Dec 29, 2022
53d066e
blurb add
brandtbucher Dec 29, 2022
eea02f9
Catch up with main
brandtbucher Jan 9, 2023
3c8830b
_PyFrame_GetComplete -> _PyFrame_GetFirstComplete
brandtbucher Jan 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Add a failing regression test
  • Loading branch information
@brandtbucher
brandtbucher committed Dec 29, 2022
commit 5f182009d1533babc139ffdec2eaa495cc13ce6e
21 changes: 21 additions & 0 deletions Lib/test/test_frame.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import gc
import operator
import re
import sys
import textwrap
Expand Down Expand Up @@ -372,6 +373,26 @@ def run(self):
)
sneaky_frame_object = sneaky_frame_object.f_back

def test_entry_frames_are_invisible_during_teardown(self):
class C:
"""A weakrefable class."""

def f():
"""Try to find globals and locals as this frame is being cleared."""
ref = C()
# Ignore the fact that exec(C()) is a nonsense callback. We're only
# using exec here because it tries to access the current frame's
# globals and locals. If it's trying to get those from a shim frame,
# we'll crash before raising:
return weakref.ref(ref, exec)

with support.catch_unraisable_exception() as catcher:
# Call from C, so there is a shim frame directly above f:
weak = operator.call(f) # BOOM!
# Cool, we didn't crash. Check that the callback actually happened:
self.assertIs(catcher.unraisable.exc_type, TypeError)
self.assertIsNone(weak())

@unittest.skipIf(_testcapi is None, 'need _testcapi')
class TestCAPI(unittest.TestCase):
def getframe(self):
Expand Down