Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-100668: Clarify how sqlite3 maps parameters onto placeholders #100960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 11, 2023

@bedevere-bot bedevere-bot added awaiting core review docs Documentation in the Doc dir skip news labels Jan 11, 2023
@erlend-aasland erlend-aasland changed the title gh-100668: Clarify how sqlite3 maps parameters onto placeholders GH-100668: Clarify how sqlite3 maps parameters onto placeholders Jan 11, 2023
@erlend-aasland erlend-aasland linked an issue Jan 11, 2023 that may be closed by this pull request
@erlend-aasland erlend-aasland changed the title GH-100668: Clarify how sqlite3 maps parameters onto placeholders gh-100668: Clarify how sqlite3 maps parameters onto placeholders Jan 11, 2023
@erlend-aasland
Copy link
Contributor Author

What's up with Bedevere? The PR title is correct, and it points to a valid issue number.

@erlend-aasland
Copy link
Contributor Author

cc. @zzzeek

@CAM-Gerlach
Copy link
Member

What's up with Bedevere? The PR title is correct, and it points to a valid issue number.

Not 100% sure if you mean how come it didn't link the issue and the PR, or something else it did, but if you mean the former, it appears you added a skip issue label when you submitted the PR, which made Bedevere not attempt to link it. I removed that, and everything appears to work fine.

Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few comments to fix some textual issues; otherwise, LGTM

@erlend-aasland erlend-aasland merged commit 206f05a into python:main Jan 14, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖

@erlend-aasland erlend-aasland deleted the sqlite-docs/params-and-placeholders branch January 14, 2023 22:58
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 14, 2023
pythonGH-100960)

(cherry picked from commit 206f05a)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
@bedevere-bot
Copy link

GH-101044 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jan 14, 2023
@bedevere-bot
Copy link

GH-101045 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 14, 2023
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 14, 2023
pythonGH-100960)

(cherry picked from commit 206f05a)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
miss-islington added a commit that referenced this pull request Jan 14, 2023
…100960)

(cherry picked from commit 206f05a)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
miss-islington added a commit that referenced this pull request Jan 14, 2023
…100960)

(cherry picked from commit 206f05a)

Co-authored-by: Erlend E. Aasland <[email protected]>
Co-authored-by: C.A.M. Gerlach <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify how sqlite3 maps parameters onto placeholders
5 participants