Thanks to visit codestin.com
Credit goes to github.com

Skip to content

bpo-33944: note about the intended use of code in .pth files #10131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 11, 2019
Merged

bpo-33944: note about the intended use of code in .pth files #10131

merged 3 commits into from
Sep 11, 2019

Conversation

native-api
Copy link
Contributor

@native-api native-api commented Oct 26, 2018 •
edited by miss-islington
Loading

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Oct 26, 2018
terryjreedy
terryjreedy requested changes Oct 26, 2018
View reviewed changes
Copy link
Member

@terryjreedy terryjreedy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highly approve of augmenting the doc as an alternative to deprecating this useful feature. With one optional suggestion, the text looks good according to the discussion. Another core dev should approve and commit.

@bedevere-bot
Copy link

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@native-api
Copy link
Contributor Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@miss-islington
Copy link
Contributor

Sorry, I can't merge this PR. Reason: Base branch was modified. Review and try the merge again..

@miss-islington miss-islington merged commit f9b5840 into python:master Sep 11, 2019
@miss-islington
Copy link
Contributor

Thanks @native-api for the PR 🌮🎉.. I'm working now to backport this PR to: 3.8.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 11, 2019
@native-api @miss-islington
bpo-33944: note about the intended use of code in .pth files (pythonG…
35e0854 
…H-10131)

https://bugs.python.org/issue33944
(cherry picked from commit f9b5840)

Co-authored-by: native-api <[email protected]>
@bedevere-bot
Copy link

GH-15942 is a backport of this pull request to the 3.8 branch.

matrixise pushed a commit that referenced this pull request Sep 11, 2019
@miss-islington @native-api @matrixise
bpo-33944: note about the intended use of code in .pth files (GH-10131)…
d1d968d 
… (GH-15942)

https://bugs.python.org/issue33944
(cherry picked from commit f9b5840)

Co-authored-by: native-api <[email protected]>
DinoV pushed a commit to DinoV/cpython that referenced this pull request Sep 12, 2019
@native-api @DinoV
bpo-33944: note about the intended use of code in .pth files (pythonG…
56babe9 
…H-10131)

https://bugs.python.org/issue33944
websurfer5 pushed a commit to websurfer5/cpython that referenced this pull request Jul 20, 2020
@native-api @websurfer5
bpo-33944: note about the intended use of code in .pth files (pythonG…
89ba4f2 
…H-10131)

https://bugs.python.org/issue33944
@native-api native-api deleted the pth_note branch September 13, 2023 20:15
@warsaw warsaw mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees
No one assigned
Labels
docs Documentation in the Doc dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@native-api @bedevere-bot @miss-islington @terryjreedy @matrixise @the-knights-who-say-ni