Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-101479: Improve clinic code for subclass_of checks #101480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

gh-101479: Improve clinic code for subclass_of checks #101480

wants to merge 1 commit into from

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 31, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Jan 31, 2023
Closed
@erlend-aasland erlend-aasland marked this pull request as ready for review February 1, 2023 08:07
serhiy-storchaka
serhiy-storchaka reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, there is no reason to do this from performance point of view. In many case it is just an address of the global variable. It only churns the code.

serhiy-storchaka
serhiy-storchaka reviewed Feb 1, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to just make clinic_state() faster?

@erlend-aasland
Copy link
Contributor Author

Is there a way to just make clinic_state() faster?

It depends on the particular case, but yes there is. See also #101476

As you say, there is no performance gain, so I'm fine with closing this PR/issue. Thanks for you input!

@erlend-aasland erlend-aasland added the pending The issue will be closed if no feedback is provided label Feb 1, 2023
@erlend-aasland erlend-aasland deleted the clinic-subclass-of branch February 1, 2023 11:38
@erlend-aasland erlend-aasland removed the pending The issue will be closed if no feedback is provided label Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

Assignees
No one assigned
Labels
awaiting core review skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@erlend-aasland @serhiy-storchaka @bedevere-bot