-
-
Notifications
You must be signed in to change notification settings - Fork 33.7k
gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) #102193
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Skipping news because these are internal-only changes, and the fact of PyErr_Fetch/Restore being obsolete is already in the news. |
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 9abebe0 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
There's a refcount issue somewhere. Checking. |
|
I must say this is a great improvement in readability. The new API is indeed a better API. Thanks! |
9abebe0 to
b5150cc
Compare
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 603922d 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit df86e20 🤖 If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again. |
|
🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit f29ca0b 🤖 If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again. |
|
There's only one failure now, in an AMD64 RHEL7 builedbot which has been flaky for a couple of months. I'll call it a pass. |
It passes now, so this PR should be fine. |
markshannon
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One minor edit needed, otherwise LGTM.
|
When you're done making the requested changes, leave the comment: |
This PR does most of Python/.