Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

@iritkatriel
Copy link
Member

@iritkatriel iritkatriel commented Feb 23, 2023

@iritkatriel
Copy link
Member Author

Skipping news because these are internal-only changes, and the fact of PyErr_Fetch/Restore being obsolete is already in the news.

@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 9abebe0 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@iritkatriel iritkatriel changed the title gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (Objects/ and Python/) Feb 24, 2023
@iritkatriel
Copy link
Member Author

There's a refcount issue somewhere. Checking.

@erlend-aasland
Copy link
Contributor

I must say this is a great improvement in readability. The new API is indeed a better API. Thanks!

@iritkatriel iritkatriel changed the title gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (Objects/ and Python/) gh-102192: Replace PyErr_Fetch/Restore etc by more efficient alternatives (in Python/) Feb 24, 2023
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit 603922d 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 24, 2023
@iritkatriel iritkatriel added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 25, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit df86e20 🤖

If you want to schedule another build, you need to add the 🔨 test-with-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 25, 2023
@iritkatriel iritkatriel added the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 26, 2023
@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @iritkatriel for commit f29ca0b 🤖

If you want to schedule another build, you need to add the 🔨 test-with-refleak-buildbots label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-refleak-buildbots Test PR w/ refleak buildbots; report in status section label Feb 26, 2023
@iritkatriel
Copy link
Member Author

There's only one failure now, in an AMD64 RHEL7 builedbot which has been flaky for a couple of months. I'll call it a pass.

@iritkatriel
Copy link
Member Author

There's only one failure now, in an AMD64 RHEL7 builedbot

It passes now, so this PR should be fine.

Copy link
Member

@markshannon markshannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor edit needed, otherwise LGTM.

@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@iritkatriel iritkatriel merged commit 4c87537 into python:main Feb 28, 2023
@iritkatriel iritkatriel deleted the fetch-restore branch April 3, 2023 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants