Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-102950: Implement PEP 706 – Filter for tarfile.extractall #102953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
encukou merged 16 commits into from
Apr 24, 2023
Merged

gh-102950: Implement PEP 706 – Filter for tarfile.extractall #102953

Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
cde089c
Implement PEP 706 – Filter for tarfile.extractall
encukou Jan 31, 2023
2395c92
Add a blurb
encukou Mar 23, 2023
561a9d4
Remove unneeded backslashes in docs
encukou Mar 27, 2023
54b5644
Fix typos in docs & comments
encukou Mar 27, 2023
7867fc3
Clarify the arguments to register_unpack_format's +function* argument
encukou Mar 27, 2023
734190d
tests: Clean up unused variables and unnecessary f-strings
encukou Mar 27, 2023
d55ae42
Make filter keyword-only in shutil
encukou Apr 6, 2023
c795bb3
Address documentation review
encukou Apr 6, 2023
5d850cc
Fix ReST syntax
encukou Apr 6, 2023
81e9050
Merge main branch to resolve conflict in Whatsnew
encukou Apr 11, 2023
de11090
Remove typo
encukou Apr 11, 2023
b0c0674
Improve errorlevel handling
encukou Apr 18, 2023
3796fdf
Fix the tests to match the PEP update
encukou Apr 19, 2023
08ab551
Document type of errorlevel
encukou Apr 19, 2023
0474842
Skip symlink-related test failures on WASI
encukou Apr 20, 2023
a255634
Ignore unrelated errors in NoneInfoTests_Misc.test_add
encukou Apr 20, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Skip symlink-related test failures on WASI
  • Loading branch information
@encukou
encukou committed Apr 20, 2023
commit 0474842cbba56877557bd825bd987625c1b52e4e
18 changes: 18 additions & 0 deletions Lib/test/test_tarfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3332,6 +3332,19 @@ def open(self, **kwargs):
bio = io.BytesIO(self.contents)
return tarfile.open(fileobj=bio, **kwargs)

# Under WASI, `os_helper.can_symlink` is False to make
# `skip_unless_symlink` skip symlink tests. "
# But in the following tests we use can_symlink to *determine* which
# behavior is expected.
# Like other symlink tests, skip these on WASI for now.
if support.is_wasi:
def symlink_test(f):
return unittest.skip("WASI: Skip symlink test for now")(f)
else:
def symlink_test(f):
return f


class TestExtractionFilters(unittest.TestCase):

# A temporary directory for the extraction results.
Expand Down Expand Up @@ -3441,6 +3454,7 @@ def test_absolute(self):
tarfile.AbsolutePathError,
"""['"].*escaped.evil['"] has an absolute path""")

@symlink_test
def test_parent_symlink(self):
# Test interplaying symlinks
# Inspired by 'dirsymlink2a' in jwilk/traversal-archives
Expand Down Expand Up @@ -3484,6 +3498,7 @@ def test_parent_symlink(self):
with self.check_context(arc.open(), 'data'):
self.expect_file('parent/evil')

@symlink_test
def test_parent_symlink2(self):
# Test interplaying symlinks
# Inspired by 'dirsymlink2b' in jwilk/traversal-archives
Expand Down Expand Up @@ -3518,6 +3533,7 @@ def test_parent_symlink2(self):
"""'current/parent' would link to ['"].*['"], """
+ "which is outside the destination")

@symlink_test
def test_absolute_symlink(self):
# Test symlink to an absolute path
# Inspired by 'dirsymlink' in jwilk/traversal-archives
Expand Down Expand Up @@ -3547,6 +3563,7 @@ def test_absolute_symlink(self):
tarfile.AbsoluteLinkError,
"'parent' is a symlink to an absolute path")

@symlink_test
def test_sly_relative0(self):
# Inspired by 'relative0' in jwilk/traversal-archives
with ArchiveMaker() as arc:
Expand Down Expand Up @@ -3580,6 +3597,7 @@ def test_sly_relative0(self):
+ "'.*moo', which is outside "
+ "the destination")

@symlink_test
def test_sly_relative2(self):
# Inspired by 'relative2' in jwilk/traversal-archives
with ArchiveMaker() as arc:
Expand Down