Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-102433: Use inspect.getattr_static in typing._ProtocolMeta.__instancecheck__ #103034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlexWaygood merged 11 commits into from
Apr 2, 2023
Merged

gh-102433: Use inspect.getattr_static in typing._ProtocolMeta.__instancecheck__ #103034

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
212fce2
Implementation
AlexWaygood Mar 24, 2023
ef71395
Tests
AlexWaygood Mar 24, 2023
4407d60
docs
AlexWaygood Mar 25, 2023
44eba6b
Wrong issue number
AlexWaygood Mar 25, 2023
9989eea
Merge branch 'main' into runtime-protocols-getattr_static
AlexWaygood Mar 27, 2023
102772c
Merge remote-tracking branch 'origin/main' into runtime-protocols-get…
AlexWaygood Mar 31, 2023
5c15fbc
Fix an edge case
AlexWaygood Mar 31, 2023
b0a9dd1
Merge branch 'runtime-protocols-getattr_static' of https://github.com…
AlexWaygood Mar 31, 2023
0812183
Move tests around, add some more
AlexWaygood Mar 31, 2023
83d7ec2
Merge branch 'main' into runtime-protocols-getattr_static
AlexWaygood Apr 2, 2023
6ba97e7
Simplify and optimise
AlexWaygood Apr 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Simplify and optimise
  • Loading branch information
@AlexWaygood
AlexWaygood committed Apr 2, 2023
commit 6ba97e71b14c86ce703fc38feacb3cff48b4785a
6 changes: 3 additions & 3 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2036,11 +2036,11 @@ def __instancecheck__(cls, instance):
return True

if is_protocol_cls:
sentinel = object()
getattr_static = _lazy_load_getattr_static()
for attr in protocol_attrs:
val = getattr_static(instance, attr, sentinel)
if val is sentinel:
try:
val = getattr_static(instance, attr)
except AttributeError:
break
if callable(getattr(cls, attr, None)) and val is None:
break
Expand Down