Thanks to visit codestin.com
Credit goes to github.com

Skip to content

gh-103046: Display current line correctly for dis.disco() with CACHE entries #103047

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 5 commits into from
Mar 27, 2023
Merged

gh-103046: Display current line correctly for dis.disco() with CACHE entries #103047

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bfaf1d2
Display current line correctly with CACHE
gaogaotiantian Mar 26, 2023
a5cd6d8
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 26, 2023
dfadcd6
Improve cache test to explicitly find CACHE entry
gaogaotiantian Mar 27, 2023
6a8b9ab
Update Misc/NEWS.d/next/Library/2023-03-26-20-54-57.gh-issue-103046.x…
gaogaotiantian Mar 27, 2023
e27ffc2
Add checks for the current line indicator
gaogaotiantian Mar 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add checks for the current line indicator
  • Loading branch information
@gaogaotiantian
gaogaotiantian committed Mar 27, 2023
commit e27ffc2f91bbc0831432fa64f255884f3a6a6c7f
9 changes: 7 additions & 2 deletions Lib/test/test_dis.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1218,8 +1218,13 @@ def f():
else:
self.fail("Can't find a CACHE entry in the function provided to do the test")

self.assertEqual(self.get_disassembly(f.__code__, lasti=op_offset, wrapper=False),
self.get_disassembly(f.__code__, lasti=cache_offset, wrapper=False))
assem_op = self.get_disassembly(f.__code__, lasti=op_offset, wrapper=False)
assem_cache = self.get_disassembly(f.__code__, lasti=cache_offset, wrapper=False)

# Make sure --> exists and points to the correct offset
self.assertRegex(assem_op, fr"-->\s+{op_offset}")
# Make sure when lasti points to cache, it shows the same disassembly
self.assertEqual(assem_op, assem_cache)


class DisWithFileTests(DisTests):
Expand Down